diff options
| author | fanquake <fanquake@gmail.com> | 2019-09-23 12:41:32 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-09-23 12:53:50 +0800 |
| commit | 3ce829888861a6dc6a29da669584ada961d965fa (patch) | |
| tree | 4eb4b5a12182e78db6e186daf6bfef54cc091580 /src/netbase.h | |
| parent | 13377b7a695c2fc774946cfd6a9aa01dd338e13c (diff) | |
| parent | 6170ec5d3ac2bc206068b270e5722a7ecd3a8f26 (diff) | |
Merge #15558: Don't query all DNS seeds at once
6170ec5d3ac2bc206068b270e5722a7ecd3a8f26 Do not query all DNS seed at once (Pieter Wuille)
Pull request description:
Before this PR, when we don't have enough connections after 11 seconds, we proceed to query all DNS seeds in a fixed order, loading responses from all of them.
Change this to to only query three randomly-selected DNS seed. If 11 seconds later we still don't have enough connections, try again with another one, and so on.
This reduces the amount of information DNS seeds can observe about the requesters by spreading the load over all of them.
ACKs for top commit:
Sjors:
ACK 6170ec5d3
sdaftuar:
ACK 6170ec5d3ac2bc206068b270e5722a7ecd3a8f26
jonasschnelli:
utACK 6170ec5d3ac2bc206068b270e5722a7ecd3a8f26 - I think the risk of a single seeder codebase is orthogonal to this PR. Such risks could also be interpreted differently (diversity could also increase the risk based on the threat model).
fanquake:
ACK 6170ec5d3ac2bc206068b270e5722a7ecd3a8f26 - Agree with the reasoning behind the change. Did some testing with and without `-forcednsseed` and/or a `peers.dat` and monitored the DNS activity.
Tree-SHA512: 33f6be5f924a85d312303ce272aa8f8d5e04cb616b4b492be98832e3ff37558d13d2b16ede68644ad399aff2bf5ff0ad33844e55eb40b7f8e3fddf9ae43add57
Diffstat (limited to 'src/netbase.h')
0 files changed, 0 insertions, 0 deletions