diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-02-15 15:20:20 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-02-15 15:22:21 +0100 |
| commit | cb073bed0056d113fede4510ec68c5a6141ca997 (patch) | |
| tree | f2847767cdb43f806eb628f61fcb0103388fd7b6 /src/netbase.cpp | |
| parent | d19639d2b6e704735b689d646828d59c11c1529b (diff) | |
| parent | 2ee4a7a9ec68c75094685c06ec793b614f44c4ce (diff) | |
| download | bitcoin-cb073bed0056d113fede4510ec68c5a6141ca997.tar.xz | |
Merge #21167: net: make CNode::m_inbound_onion public, initialize explicitly
2ee4a7a9ec68c75094685c06ec793b614f44c4ce net: remove CNode::m_inbound_onion defaults for explicitness (Jon Atack)
24bda56c29800502953c6a8cd69248e60ff9a0a0 net: make CNode::m_inbound_onion public, drop getter, update tests (Jon Atack)
Pull request description:
Refactoring only, no change in behavior. This is a quick follow-up to #20210 to address these review comments:
- https://github.com/bitcoin/bitcoin/pull/20210#discussion_r528835313
- https://github.com/bitcoin/bitcoin/pull/20210#discussion_r550860416
- https://github.com/bitcoin/bitcoin/pull/20210#issuecomment-766093925
Changes:
- make the `CNode::m_inbound_onion class` member public, update the Doxygen comment, drop the getter, and update the tests
- remove the `CNode::m_inbound_onion` default value initialization in the ctor declaration and the member initializer in favor of always passing it explicitly to the ctor where we initialize it dynamically, to both clarify the caller code and to allow the compiler to warn if it is uninitialized in the ctor or omitted in the caller
ACKs for top commit:
MarcoFalke:
review ACK 2ee4a7a9ec68c75094685c06ec793b614f44c4ce 🏀
vasild:
ACK 2ee4a7a9ec68c75094685c06ec793b614f44c4ce
Tree-SHA512: 72961c91168885a9d881756b10bad9d587f5ce297d5a6493c23e267b7178ff22b697bc6868e7761d6304e372d2781453d30011a020afd506b1e308b4ffa5feee
Diffstat (limited to 'src/netbase.cpp')
0 files changed, 0 insertions, 0 deletions