diff options
| author | Greg Sanders <gsanders87@gmail.com> | 2023-06-23 12:20:54 -0400 |
|---|---|---|
| committer | Greg Sanders <gsanders87@gmail.com> | 2023-06-23 12:20:54 -0400 |
| commit | 9fe5f6d5d1ec31ebfacfe23368f22c2a0b58832d (patch) | |
| tree | 91d99cff11eaddfaa4d9d30de2a888ec030001a5 /src/net_processing.cpp | |
| parent | 6a473373d4953cabbb219eae8b709150a45796e6 (diff) | |
MaybePunishNodeForTx: Remove unused message arg and logging
Diffstat (limited to 'src/net_processing.cpp')
| -rw-r--r-- | src/net_processing.cpp | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/net_processing.cpp b/src/net_processing.cpp index 6597019797..f1862d62a0 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -568,7 +568,7 @@ private: * * @return Returns true if the peer was punished (probably disconnected) */ - bool MaybePunishNodeForTx(NodeId nodeid, const TxValidationState& state, const std::string& message = "") + bool MaybePunishNodeForTx(NodeId nodeid, const TxValidationState& state) EXCLUSIVE_LOCKS_REQUIRED(!m_peer_mutex); /** Maybe disconnect a peer and discourage future connections from its address. @@ -1731,7 +1731,7 @@ bool PeerManagerImpl::MaybePunishNodeForBlock(NodeId nodeid, const BlockValidati return false; } -bool PeerManagerImpl::MaybePunishNodeForTx(NodeId nodeid, const TxValidationState& state, const std::string& message) +bool PeerManagerImpl::MaybePunishNodeForTx(NodeId nodeid, const TxValidationState& state) { PeerRef peer{GetPeerRef(nodeid)}; switch (state.GetResult()) { @@ -1739,7 +1739,7 @@ bool PeerManagerImpl::MaybePunishNodeForTx(NodeId nodeid, const TxValidationStat break; // The node is providing invalid data: case TxValidationResult::TX_CONSENSUS: - if (peer) Misbehaving(*peer, 100, message); + if (peer) Misbehaving(*peer, 100, ""); return true; // Conflicting (but not necessarily invalid) data or different policy: case TxValidationResult::TX_RECENT_CONSENSUS_CHANGE: @@ -1754,9 +1754,6 @@ bool PeerManagerImpl::MaybePunishNodeForTx(NodeId nodeid, const TxValidationStat case TxValidationResult::TX_NO_MEMPOOL: break; } - if (message != "") { - LogPrint(BCLog::NET, "peer=%d: %s\n", nodeid, message); - } return false; } |