diff options
author | dergoegge <n.goeggi@gmail.com> | 2022-10-20 17:55:44 +0100 |
---|---|---|
committer | dergoegge <n.goeggi@gmail.com> | 2022-10-21 11:05:34 +0100 |
commit | 7ad15d11005eac36421398530da127333d87ea80 (patch) | |
tree | d124550f8438d29ed6650d886ca38438cba15511 /src/net_processing.cpp | |
parent | fabc0310480b49e159a15d494525c5aa15072cba (diff) |
[net processing] Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started
Diffstat (limited to 'src/net_processing.cpp')
-rw-r--r-- | src/net_processing.cpp | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/src/net_processing.cpp b/src/net_processing.cpp index c87b0e7cd2..1c427302da 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -2565,14 +2565,22 @@ bool PeerManagerImpl::TryLowWorkHeadersSync(Peer& peer, CNode& pfrom, const CBlo // Now a HeadersSyncState object for tracking this synchronization is created, // process the headers using it as normal. - return IsContinuationOfLowWorkHeadersSync(peer, pfrom, headers); + if (!IsContinuationOfLowWorkHeadersSync(peer, pfrom, headers)) { + // Something went wrong, reset the headers sync. + peer.m_headers_sync.reset(nullptr); + LOCK(m_headers_presync_mutex); + m_headers_presync_stats.erase(peer.m_id); + } } else { LogPrint(BCLog::NET, "Ignoring low-work chain (height=%u) from peer=%d\n", chain_start_header->nHeight + headers.size(), pfrom.GetId()); - // Since this is a low-work headers chain, no further processing is required. - headers = {}; - return true; } + + // The peer has not yet given us a chain that meets our work threshold, + // so we want to prevent further processing of the headers in any case. + headers = {}; + return true; } + return false; } |