aboutsummaryrefslogtreecommitdiff
path: root/src/net.h
diff options
context:
space:
mode:
authorAnthony Towns <aj@erisian.com.au>2022-05-20 05:37:54 +1000
committerAnthony Towns <aj@erisian.com.au>2022-08-29 22:50:54 +1000
commitef26f2f421071986a3878a1a94b0149ae8e16fcd (patch)
treea156568bc6c1d947069a12bc743d7054347e9be2 /src/net.h
parentbbec32c9ad2fe213314db9d39aa1eacff2e0bc23 (diff)
downloadbitcoin-ef26f2f421071986a3878a1a94b0149ae8e16fcd.tar.xz
net: mark CNode unique_ptr members as const
Dereferencing a unique_ptr is not necessarily thread safe. The reason these are safe is because their values are set at construction and do not change later; so mark them as const and set them via the initializer list to guarantee that.
Diffstat (limited to 'src/net.h')
-rw-r--r--src/net.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/net.h b/src/net.h
index 97389314b2..d062b8a9ff 100644
--- a/src/net.h
+++ b/src/net.h
@@ -341,8 +341,8 @@ class CNode
friend struct ConnmanTestMsg;
public:
- std::unique_ptr<TransportDeserializer> m_deserializer;
- std::unique_ptr<const TransportSerializer> m_serializer;
+ const std::unique_ptr<TransportDeserializer> m_deserializer; // Used only by SocketHandler thread
+ const std::unique_ptr<const TransportSerializer> m_serializer;
NetPermissionFlags m_permissionFlags{NetPermissionFlags::None};