Merge bitcoin/bitcoin#22911: [net] Minor cleanups to asmap

853c4edb70f897a6a7165abaea4a303d7d448721 [net] Remove asmap argument from CNode::CopyStats() (John Newbery)
9fd5618610e91e3949536c5122cf31eb58c9aa6b [asmap] Make DecodeAsmap() a utility function (John Newbery)
bfdf4ef334a16ef6108a658bf4f8514754128c18 [asmap] Remove SanityCheckASMap() from netaddress (John Newbery)
07a9eccb60485e71494664cc2b1964ae06a3dcf0 [net] Remove CConnman::Options.m_asmap (John Newbery)

Pull request description:

  These small cleanups to the asmap code are the first 4 commits from #22910. They're minor improvements that are independently useful whether or not 22910 is merged.

ACKs for top commit:
  naumenkogs:
    ACK 853c4edb70f897a6a7165abaea4a303d7d448721
  theStack:
    Concept and code-review ACK 853c4edb70f897a6a7165abaea4a303d7d448721 🗺️
  fanquake:
    ACK 853c4edb70f897a6a7165abaea4a303d7d448721

Tree-SHA512: 64783743182592ac165df6ff8d18870b63861e9204ed722c207fca6938687aac43232a5ac4d8228cf8b92130ab0349de1b410a2467bb5a9d60dd9a7221b3b85b

1 files changed, 1 insertions, 2 deletions

diff --git a/src/net.h b/src/net.h
index 5aca0bd75c..0a72ca888d 100644
--- a/src/net.h
+++ b/src/net.h
@@ -651,7 +651,7 @@ public:
 
     void CloseSocketDisconnect();
 
-    void CopyStats(CNodeStats& stats, const std::vector<bool>& asmap);
+    void CopyStats(CNodeStats& stats);
 
     ServiceFlags GetLocalServices() const
     {
@@ -767,7 +767,6 @@ public:
         bool m_use_addrman_outgoing = true;
         std::vector<std::string> m_specified_outgoing;
         std::vector<std::string> m_added_nodes;
-        std::vector<bool> m_asmap;
         bool m_i2p_accept_incoming;
     };