diff options
| author | fanquake <fanquake@gmail.com> | 2021-12-14 20:37:28 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-12-14 20:40:58 +0800 |
| commit | 498fe4b7808e1e655953794f017b5f26d0bce8de (patch) | |
| tree | e8d8c7ff0f401bf5c09263b908db07270355508d /src/net.h | |
| parent | aaaceb7fb14fa69d34194e805bc384088f55d25c (diff) | |
| parent | fa19bab90a3ccc2f76c20aa805292d6a9c5d8071 (diff) | |
Merge bitcoin/bitcoin#23575: fuzz: Rework FillNode
fa19bab90a3ccc2f76c20aa805292d6a9c5d8071 fuzz: Rework FillNode (MarcoFalke)
fae6e31df7c6df04f41fc8401e2a9781a4d75be7 refactor: Set fSuccessfullyConnected in FillNode (MarcoFalke)
fa3583f856e34b6c6134745da14f5206cf71fa3e fuzz: Avoid negative NodeId in ConsumeNode (MarcoFalke)
Pull request description:
Currently `FillNode` is a bit clumsy because it directly modifies memory of `CNode`. This gets in the way of moving that memory to `Peer`. Also, it isn't particularly consistent. See for example https://github.com/bitcoin/bitcoin/pull/21160#discussion_r739206139 .
Fix all issues by sending a `version`/`verack` in `FillNode` and let net_processing figure out the internal details.
ACKs for top commit:
jnewbery:
Strong concept ACK and light code review ACK fa19bab90a3ccc2f76c20aa805292d6a9c5d8071
Tree-SHA512: 33261d857c3fa6d5d39d742624009a29178ad5a15eb3fd062da741affa5a4854fd45ed20d59a6bba2fb068cf7b39cad6f95b2910be7cb6afdc27cd7917955b67
Diffstat (limited to 'src/net.h')
0 files changed, 0 insertions, 0 deletions