diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-04-16 16:37:22 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-04-16 16:37:27 -0400 |
| commit | 969ee8549496108730d2c824d69d0782a43c3d7f (patch) | |
| tree | 94f84421408fb2e7410890dcaa2f1372d1515a6f /src/net.h | |
| parent | 8f2497941ef19c64b1669a9135952fc989a5027c (diff) | |
| parent | faf989f93695d29099f6e152d5a2e117cd304183 (diff) | |
Merge #18662: test: Replace gArgs with local argsman in bench
faf989f93695d29099f6e152d5a2e117cd304183 util: Document why ArgsManager (con/de)structor is not inline (MarcoFalke)
fae00a77e2589cc784650e3e60e1b99c22ca8a7b bench: Remove unused argsman.ClearArgs (MarcoFalke)
fa46aebeb1fc419b227524eab8352d9a7fc1f981 scripted-diff: Replace gArgs with local argsman in bench (MarcoFalke)
fa2bc4141df59f2e38fef863723b433250295d20 tools: Add unused argsman to bench_bitcoin (MarcoFalke)
Pull request description:
All utilities use the same gArgs global that the node uses. This is generally fine and does not lead to issues unless a bench test is going to spin up a NodeContext via the TestingSetup. In that case the two uses of gArgs conflict and currently it needs to be cleared:
https://github.com/bitcoin/bitcoin/blob/544709763e1f45148d1926831e07ff03487673ee/src/bench/bench_bitcoin.cpp#L76
One solution would be to do nothing, because the current code works with that workaround. Another solution would be to not use the same global in all binaries.
ACKs for top commit:
promag:
ACK faf989f93695d29099f6e152d5a2e117cd304183.
ryanofsky:
Code review ACK faf989f93695d29099f6e152d5a2e117cd304183. Just new commit added restoring forward declaration
Tree-SHA512: 8ee4b28eee294d41c002f801fa844b0c23c919a3061f5109638701db0947b3b0ea28caa7311ae5f126fc660648bbaa0890853e6b06bdc5868692f52ba8c05f66
Diffstat (limited to 'src/net.h')
0 files changed, 0 insertions, 0 deletions