Change CMessageHeader Constructor

This commit removes the single-parameter contructor of CMessageHeader
and replaces it with a default constructor.

The single parameter contructor isn't used anywhere except for tests.
There is no reason to initialize a CMessageHeader with a particular
messagestart.  This messagestart should always be replaced when
deserializing an actual message header so that we can run checks on it.

The default constructor initializes it to zero, just like the command
and checksum.

This also removes a parameter of a V1TransportDeserializer constructor,
as it was only used for this purpose.

1 files changed, 1 insertions, 2 deletions

diff --git a/src/net.h b/src/net.h
index f581ce8ff9..cec201c5d2 100644
--- a/src/net.h
+++ b/src/net.h
@@ -765,10 +765,9 @@ private:
     }
 
 public:
-    V1TransportDeserializer(const CMessageHeader::MessageStartChars& pchMessageStartIn, const NodeId node_id, int nTypeIn, int nVersionIn)
+    V1TransportDeserializer(const NodeId node_id, int nTypeIn, int nVersionIn)
         : m_node_id(node_id),
           hdrbuf(nTypeIn, nVersionIn),
-          hdr(pchMessageStartIn),
           vRecv(nTypeIn, nVersionIn)
     {
         Reset();