diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-05-19 10:07:25 +0200 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-05-19 10:07:53 +0200 |
| commit | 1ed859e90e18384376e3a1ff0cb76f3e9ab11c2d (patch) | |
| tree | 94fc45fb3be9eb9eb69237d9f41a12b40a4a7359 /src/net.cpp | |
| parent | 2fc111b6e3b051b45bc44267c3397cc12cadae3a (diff) | |
| parent | 74bf850ac47735f2ef4306059d3e664d40cac85e (diff) | |
| download | bitcoin-1ed859e90e18384376e3a1ff0cb76f3e9ab11c2d.tar.xz | |
Merge bitcoin/bitcoin#21173: util: faster HexStr => 13% faster blockToJSON
74bf850ac47735f2ef4306059d3e664d40cac85e faster HexStr => 13% faster blockToJSON (Martin Ankerl)
Pull request description:
`std::string`'s push_back is rather slow because it needs to check & update the string size. For
`HexStr` the output string size is already easily know, so we can initially create the string with
the correct size and then just assign the data.
`HexStr` is heavily usd in `blockToJSON`, so this change is a noticeable benefit. Benchmark on an i7-8700 @3.2GHz:
* 71,315,461.00 ns/op master
* 62,842,490.00 ns/op this commit
So this little change makes `blockToJSON` about ~13% faster.
ACKs for top commit:
laanwj:
Code review ACK 74bf850ac47735f2ef4306059d3e664d40cac85e
theStack:
re-ACK 74bf850ac47735f2ef4306059d3e664d40cac85e
Tree-SHA512: fc99105123edc11f4e40ed77aea80cf7f32e49c53369aa364b38395dcb48575e15040b0489ed30d0fe857c032a04e225c33e9d95cdfa109a3cb5a6ec9a972415
Diffstat (limited to 'src/net.cpp')
0 files changed, 0 insertions, 0 deletions