diff options
| author | fanquake <fanquake@gmail.com> | 2020-09-30 12:17:06 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-09-30 12:41:22 +0800 |
| commit | c7ad94428ab6f54661d7a5441e1fdd0ebf034903 (patch) | |
| tree | 3655a0b2976800227edb15bcd81ab7d53d6d531d /src/net.cpp | |
| parent | de4b7f25acef14f98ed09b7cbaa065067313d24b (diff) | |
| parent | 2ea62cae483b764e30f61c06d8ac65755bbd864c (diff) | |
| download | bitcoin-c7ad94428ab6f54661d7a5441e1fdd0ebf034903.tar.xz | |
Merge #19958: doc: Better document features of feelers
2ea62cae483b764e30f61c06d8ac65755bbd864c Improve docs about feeler connections (Gleb Naumenko)
Pull request description:
"feeler" and "test-before-evict" are two different strategies suggest in [Eclipse Attacks on Bitcoin’s Peer-to-Peer Network](https://www.usenix.org/system/files/conference/usenixsecurity15/sec15-paper-heilman.pdf). In our codebase, we use `ConnType::FEELER` to implement both.
It is confusing, up to the point that our documentation was just incorrect.
This PR:
- ~clarifies this aspect by renaming "ConnType::FEELER" to "ConnType::PROBE", meaning that this connections only probes that the node is operational, and then disconnects.~
- fixes the documentation
ACKs for top commit:
amitiuttarwar:
ACK 2ea62cae48. thank you!
practicalswift:
ACK 2ea62cae483b764e30f61c06d8ac65755bbd864c
Tree-SHA512: c9c03c09eefeacec28ea199cc3f697b0a98723f2f849f7a8115edc43791f8165e296e0e25a82f0b5a4a781a7de38c8954b48bf74c714eba02cdc21f7460673e5
Diffstat (limited to 'src/net.cpp')
| -rw-r--r-- | src/net.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/net.cpp b/src/net.cpp index 3eac2235a5..7dec4abfb9 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -1811,7 +1811,7 @@ void CConnman::SetTryNewOutboundPeer(bool flag) // Return the number of peers we have over our outbound connection limit // Exclude peers that are marked for disconnect, or are going to be -// disconnected soon (eg one-shots and feelers) +// disconnected soon (eg ADDR_FETCH and FEELER) // Also exclude peers that haven't finished initial connection handshake yet // (so that we don't decide we're over our desired connection limit, and then // evict some peer that has finished the handshake) |