diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-01-09 14:59:57 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-01-09 15:04:36 +0100 |
| commit | 3f125151998d9fead198fd44243dd64006b5a56b (patch) | |
| tree | f6945556ab446cece8c3310c37e30d91ff66c6fc /src/net.cpp | |
| parent | e12a480e40753655124acc15fe4ebfe7bcb3ab99 (diff) | |
| parent | fa2510d5c1cdf9c2cd5cc9887302ced4378c7202 (diff) | |
| download | bitcoin-3f125151998d9fead198fd44243dd64006b5a56b.tar.xz | |
Merge #15109: refactor: Use C++11 default member initializers
fa2510d5c1cdf9c2cd5cc9887302ced4378c7202 Use C++11 default member initializers (MarcoFalke)
Pull request description:
Changes:
* Remove unused constructors that leave some members uninitialized
* Remove manual initialization in each constructor and prefer C++11 default member initializers
This is not a stylistic change, but a change that avoids bugs such as:
* fix uninitialized read when stringifying an addrLocal #14728
* qt: Initialize members in WalletModel #12426
* net: correctly initialize nMinPingUsecTime #6636
* ...
Tree-SHA512: 0f896f3b9fcc464d5fc7525f7c86343ef9ce9fb13425fbc68e9a9728fd8710c2b4e2fd039ee08279ea41ff20fd92b7185cf5cca95a0bcb6a5340a1e6f03cae6b
Diffstat (limited to 'src/net.cpp')
| -rw-r--r-- | src/net.cpp | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/net.cpp b/src/net.cpp index 902830f79c..03ee7af5e4 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -2316,14 +2316,6 @@ void CConnman::SetNetworkActive(bool active) CConnman::CConnman(uint64_t nSeed0In, uint64_t nSeed1In) : nSeed0(nSeed0In), nSeed1(nSeed1In) { - fNetworkActive = true; - setBannedIsDirty = false; - fAddressesInitialized = false; - nLastNodeId = 0; - nPrevNodeCount = 0; - nSendBufferMaxSize = 0; - nReceiveFloodSize = 0; - flagInterruptMsgProc = false; SetTryNewOutboundPeer(false); Options connOptions; |