aboutsummaryrefslogtreecommitdiff
path: root/src/net.cpp
diff options
context:
space:
mode:
authorGregory Maxwell <greg@xiph.org>2016-11-27 02:47:22 +0000
committerGregory Maxwell <greg@xiph.org>2016-11-27 04:13:54 +0000
commit083f20369878196785151e038e5f5126fed74021 (patch)
treec57369aeff2af76a042bca5a23f64ba321bf0ac7 /src/net.cpp
parent76fec09d878d6dbf214bdb6228d480bd9195db4c (diff)
downloadbitcoin-083f20369878196785151e038e5f5126fed74021.tar.xz
Remove fNetworkNode.
Matt pointed out to me that this appeared to be doing nothing (except involving itself in data races).
Diffstat (limited to 'src/net.cpp')
-rw-r--r--src/net.cpp5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/net.cpp b/src/net.cpp
index ce87150ae3..08115a3518 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -1067,8 +1067,7 @@ void CConnman::ThreadSocketHandler()
pnode->CloseSocketDisconnect();
// hold in disconnected pool until all refs are released
- if (pnode->fNetworkNode || pnode->fInbound)
- pnode->Release();
+ pnode->Release();
vNodesDisconnected.push_back(pnode);
}
}
@@ -1808,7 +1807,6 @@ bool CConnman::OpenNetworkConnection(const CAddress& addrConnect, bool fCountFai
return false;
if (grantOutbound)
grantOutbound->MoveTo(pnode->grantOutbound);
- pnode->fNetworkNode = true;
if (fOneShot)
pnode->fOneShot = true;
if (fFeeler)
@@ -2531,7 +2529,6 @@ CNode::CNode(NodeId idIn, ServiceFlags nLocalServicesIn, int nMyStartingHeightIn
fOneShot = false;
fClient = false; // set by version message
fFeeler = false;
- fNetworkNode = false;
fSuccessfullyConnected = false;
fDisconnect = false;
nRefCount = 0;