RPC help documentation for addnode peerinfo.

Also adds a comment about the netgroup exclusion behavior.

1 files changed, 5 insertions, 0 deletions

diff --git a/src/net.cpp b/src/net.cpp
index 6640cc0016..0f0a7bf8dc 100644
--- a/src/net.cpp
+++ b/src/net.cpp
@@ -1633,6 +1633,11 @@ void CConnman::ThreadOpenConnections()
             LOCK(cs_vNodes);
             BOOST_FOREACH(CNode* pnode, vNodes) {
                 if (!pnode->fInbound && !pnode->fAddnode) {
+                    // Netgroups for inbound and addnode peers are not excluded because our goal here
+                    // is to not use multiple of our limited outbound slots on a single netgroup
+                    // but inbound and addnode peers do not use our outbound slots.  Inbound peers
+                    // also have the added issue that they're attacker controlled and could be used
+                    // to prevent us from connecting to particular hosts if we used them here.
                     setConnected.insert(pnode->addr.GetGroup());
                     nOutbound++;
                 }