diff options
| author | Giel van Schijndel <me@mortis.eu> | 2012-06-24 14:02:14 +0200 |
|---|---|---|
| committer | Giel van Schijndel <me@mortis.eu> | 2012-07-17 01:48:03 +0200 |
| commit | f04f24503d7ea9b943d0a940465618b93ff4577d (patch) | |
| tree | f417cbeba93337438bac1fdab35eed3dfb9aabf5 /src/makefile.unix | |
| parent | 1c009d622ded6dd254d6be5161b4df875d492d12 (diff) | |
| download | bitcoin-f04f24503d7ea9b943d0a940465618b93ff4577d.tar.xz | |
Use linker-arguments only when linking
Passing linker-arguments when only compiling will cause warnings with
Clang. This change fixes those.
Signed-off-by: Giel van Schijndel <me@mortis.eu>
Diffstat (limited to 'src/makefile.unix')
| -rw-r--r-- | src/makefile.unix | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/src/makefile.unix b/src/makefile.unix index 2784335a20..a81300329e 100644 --- a/src/makefile.unix +++ b/src/makefile.unix @@ -66,13 +66,14 @@ LIBS+= \ # Make some important things such as the global offset table read only as soon as # the dynamic linker is finished building it. This will prevent overwriting of addresses # which would later be jumped to. - HARDENING+=-Wl,-z,relro -Wl,-z,now + LDHARDENING+=-Wl,-z,relro -Wl,-z,now # Build position independent code to take advantage of Address Space Layout Randomization # offered by some kernels. # see doc/build-unix.txt for more information. ifdef PIE - HARDENING+=-fPIE -pie + HARDENING+=-fPIE + LDHARDENING+=-pie endif # -D_FORTIFY_SOURCE=2 does some checking for potentially exploitable code patterns in @@ -88,6 +89,10 @@ DEBUGFLAGS=-g xCXXFLAGS=-O2 -pthread -Wall -Wextra -Wformat -Wformat-security -Wno-unused-parameter \ $(DEBUGFLAGS) $(DEFS) $(HARDENING) $(CXXFLAGS) +# LDFLAGS can be specified on the make command line, so we use xLDFLAGS that only +# adds some defaults in front. Unfortunately, LDFLAGS=... $(LDFLAGS) does not work. +xLDFLAGS=$(LDHARDENING) $(LDFLAGS) + OBJS= \ obj/version.o \ obj/checkpoints.o \ @@ -133,7 +138,7 @@ obj/%.o: %.cpp rm -f $(@:%.o=%.d) bitcoind: $(OBJS:obj/%=obj/%) - $(CXX) $(xCXXFLAGS) -o $@ $^ $(LDFLAGS) $(LIBS) + $(CXX) $(xCXXFLAGS) -o $@ $^ $(xLDFLAGS) $(LIBS) TESTOBJS := $(patsubst test/%.cpp,obj-test/%.o,$(wildcard test/*.cpp)) @@ -145,7 +150,7 @@ obj-test/%.o: test/%.cpp rm -f $(@:%.o=%.d) test_bitcoin: $(TESTOBJS) $(filter-out obj/init.o,$(OBJS:obj/%=obj/%)) - $(CXX) $(xCXXFLAGS) -o $@ $(LIBPATHS) $^ -Wl,-B$(LMODE) -lboost_unit_test_framework $(LDFLAGS) $(LIBS) + $(CXX) $(xCXXFLAGS) -o $@ $(LIBPATHS) $^ -Wl,-B$(LMODE) -lboost_unit_test_framework $(xLDFLAGS) $(LIBS) clean: -rm -f bitcoind test_bitcoin |