diff options
| author | Gregory Maxwell <greg@xiph.org> | 2015-11-01 20:05:18 +0000 |
|---|---|---|
| committer | Gregory Maxwell <greg@xiph.org> | 2015-11-01 20:05:18 +0000 |
| commit | 40cd32e835092c3158175511da5193193ec54939 (patch) | |
| tree | a277d4f0514dc26c86c8fa86ab831acd6ed3e63f /src/main.h | |
| parent | 8537ecdfc40181249ec37556015a99cfae4b21fd (diff) | |
| download | bitcoin-40cd32e835092c3158175511da5193193ec54939.tar.xz | |
Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations"
This reverts commit 9d55050773d57c0e12005e524f2e54d9e622c6e2.
As noted by Luke-Jr, under some conditions this will accept transactions which are invalid by the network
rules. This happens when the current block time is head of the median time past and a transaction's
locktime is in the middle.
This could be addressed by changing the rule to MAX(this_block_time, MTP+offset) but this solution and
the particular offset used deserve some consideration.
Diffstat (limited to 'src/main.h')
| -rw-r--r-- | src/main.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/main.h b/src/main.h index 65732d770f..202d2c772b 100644 --- a/src/main.h +++ b/src/main.h @@ -308,10 +308,8 @@ bool IsFinalTx(const CTransaction &tx, int nBlockHeight, int64_t nBlockTime); * Check if transaction will be final in the next block to be created. * * Calls IsFinalTx() with current block height and appropriate block time. - * - * See consensus/consensus.h for flag definitions. */ -bool CheckFinalTx(const CTransaction &tx, int flags = -1); +bool CheckFinalTx(const CTransaction &tx); /** * Closure representing one script verification |