Locking fix for AlreadyHave()

Access to mapTransactions[] must be guarded by cs_mapTransactions lock.

1 files changed, 8 insertions, 1 deletions

diff --git a/src/main.cpp b/src/main.cpp
index 059dd3db9e..57c18aed48 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -1953,7 +1953,14 @@ bool static AlreadyHave(CTxDB& txdb, const CInv& inv)
 {
     switch (inv.type)
     {
-    case MSG_TX:    return mapTransactions.count(inv.hash) || mapOrphanTransactions.count(inv.hash) || txdb.ContainsTx(inv.hash);
+    case MSG_TX:
+        CRITICAL_BLOCK(cs_mapTransactions)
+        {
+            return mapTransactions.count(inv.hash) ||
+                   mapOrphanTransactions.count(inv.hash) ||
+                   txdb.ContainsTx(inv.hash);
+        }
+
     case MSG_BLOCK: return mapBlockIndex.count(inv.hash) || mapOrphanBlocks.count(inv.hash);
     }
     // Don't know what it is, just say we already got one