diff options
| author | glozow <gloriajzhao@gmail.com> | 2023-03-23 15:44:42 +0000 |
|---|---|---|
| committer | glozow <gloriajzhao@gmail.com> | 2023-03-23 15:53:56 +0000 |
| commit | 381593c906fb54340dbc2377e2ebc6fb37582d08 (patch) | |
| tree | 6c36e9050529ba95d3e2c8c914244e8fc3f4f903 /src/logging.cpp | |
| parent | 483fb8d2165bacafe9c12a829afca248feeeb42f (diff) | |
| parent | f3221d373a8623fe4808e00c7a92fbb6e0d6419b (diff) | |
| download | bitcoin-381593c906fb54340dbc2377e2ebc6fb37582d08.tar.xz | |
Merge bitcoin/bitcoin#24845: wallet: return error msg for "too-long-mempool-chain"
f3221d373a8623fe4808e00c7a92fbb6e0d6419b test: add wallet too-long-mempool-chain error coverage (furszy)
acf0119d24c9f8fae825093249a46cd38e4a3a91 wallet: return error msg for too-long-mempool-chain failure (furszy)
Pull request description:
Fixes #23144.
We currently return a general "Insufficient funds" from Coin
Selection when we actually skipped unconfirmed UTXOs that
surpassed the mempool ancestors limit.
This PR make the error clearer by returning:
"Unconfirmed UTXOs are available, but spending them creates
a chain of transactions that will be rejected by the mempool"
Also, added an early return from Coin Selection if the sum of
the discarded coins decreases the available balance below the
target amount.
ACKs for top commit:
achow101:
ACK f3221d373a8623fe4808e00c7a92fbb6e0d6419b
S3RK:
Code review ACK f3221d373a8623fe4808e00c7a92fbb6e0d6419b
Xekyo:
ACK f3221d373a8623fe4808e00c7a92fbb6e0d6419b
Tree-SHA512: 13e5824b75ac302280ff894560a4ebf32a74f32fe49ef8281f2bc99c0104b92cef33d3b143c6e131f3a07eafe64533af7fc60abff585142c134b9d6e531a6a66
Diffstat (limited to 'src/logging.cpp')
0 files changed, 0 insertions, 0 deletions