diff options
author | W. J. van der Laan <laanwj@protonmail.com> | 2021-12-17 21:42:30 +0100 |
---|---|---|
committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-12-17 21:44:59 +0100 |
commit | 14ba286556faad794f288ef38493c540382897cb (patch) | |
tree | 36165b3796cf0c81b1ac594ec386e35246419195 /src/key.cpp | |
parent | 784a21d35466736a7a372364498ed94482a12a2a (diff) | |
parent | fa1dc9b36a0ccf96cbaf106c060336d91b54579e (diff) | |
download | bitcoin-14ba286556faad794f288ef38493c540382897cb.tar.xz |
Merge bitcoin/bitcoin#23695: p2p: Always serialize local timestamp for version msg
fa1dc9b36a0ccf96cbaf106c060336d91b54579e p2p: Always serialize local timestamp for version msg (MarcoFalke)
Pull request description:
Currently we serialize the local time when connecting to outbound connections and the "adjusted network" time when someone connects to us.
I presume the reason is to avoid a fingerprint in case the local time is misconfigured. However, the fingerprint still exits when:
* The local time goes out-of-sync after timedata is filled up, in which case the adjusted time is *not* adjusted. See comment in `src/timedata.cpp`. (In practise I expect no adjustment to happen after timedata is filled up by one entry more than half its size).
* The local time is off by more than 70 minutes. See `DEFAULT_MAX_TIME_ADJUSTMENT`. While there is a warning in this case, the warning might be missed by the node operator.
* The adjusted time is poisoned by an attacker. This is only a theoretical concern after commit e457513eb1bad11482f0820feb0f5810324a9d06.
Using the adjusted time does help in a the case where the local time is off by a constant less than 70 minutes and the node quickly connects to 5 outbound peers to retrieve the adjusted time.
Still, I think using `GetAdjustedTime` here gives a false sense of security. It will be better for node operators to instead set the correct time.
ACKs for top commit:
naumenkogs:
ACK fa1dc9b36a0ccf96cbaf106c060336d91b54579e
laanwj:
Code review ACK fa1dc9b36a0ccf96cbaf106c060336d91b54579e
w0xlt:
crACK fa1dc9b
Tree-SHA512: 70a0f4ab3500e6ddcde291620e35273018cefd1d9e94b91ad333e360139ed18862718bb1a9854af2bf79990bf74b05d95492f77d0747c7b9bdd276c020116dcb
Diffstat (limited to 'src/key.cpp')
0 files changed, 0 insertions, 0 deletions