diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-06-06 16:41:24 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-06-06 16:41:40 +0200 |
| commit | d0f81a96d9c158a9226dc946bdd61d48c4d42959 (patch) | |
| tree | b3c31f70a35fe6ffcd872714afb4df6005f3df44 /src/interfaces | |
| parent | 36fb968825a19aa1b01661228ba53209ec7a033e (diff) | |
| parent | 67f4e9c52270f9ddf8f7e83f0906af5e6743b33a (diff) | |
Merge #16129: refactor: Remove unused includes
67f4e9c522 Include core_io.h from core_read.cpp (practicalswift)
eca9767673 Make reasoning about dependencies easier by not including unused dependencies (practicalswift)
Pull request description:
Make reasoning about dependencies easier by not including unused dependencies.
Please note that the removed headers are _not_ "transitively included" by other still included headers. Thus the removals are real.
As an added bonus this change means less work for the preprocessor/compiler. At least 51 393 lines of code no longer needs to be processed:
```
$ git diff -u HEAD~1 | grep -E '^\-#include ' | cut -f2 -d"<" | cut -f1 -d">" | \
sed 's%^%src/%g' | xargs cat | wc -l
51393
```
Note that 51 393 is the lower bound: the real number is likely much higher when taking into account transitively included headers :-)
ACKs for commit 67f4e9:
Tree-SHA512: 0c8868aac59813f099ce53d5307eed7962dd6f2ff3546768ef9e5c4508b87f8210f1a22c7e826c3c06bebbf28bdbfcf1628ed354c2d0fdb9a31a42cefb8fdf13
Diffstat (limited to 'src/interfaces')
| -rw-r--r-- | src/interfaces/node.cpp | 1 | ||||
| -rw-r--r-- | src/interfaces/wallet.cpp | 8 |
2 files changed, 0 insertions, 9 deletions
diff --git a/src/interfaces/node.cpp b/src/interfaces/node.cpp index 15646b0ff4..584d218dba 100644 --- a/src/interfaces/node.cpp +++ b/src/interfaces/node.cpp @@ -23,7 +23,6 @@ #include <policy/settings.h> #include <primitives/block.h> #include <rpc/server.h> -#include <scheduler.h> #include <shutdown.h> #include <sync.h> #include <txmempool.h> diff --git a/src/interfaces/wallet.cpp b/src/interfaces/wallet.cpp index b57299d78d..240670cbe7 100644 --- a/src/interfaces/wallet.cpp +++ b/src/interfaces/wallet.cpp @@ -5,27 +5,19 @@ #include <interfaces/wallet.h> #include <amount.h> -#include <chain.h> #include <consensus/validation.h> -#include <init.h> #include <interfaces/chain.h> #include <interfaces/handler.h> -#include <net.h> #include <policy/feerate.h> #include <policy/fees.h> -#include <policy/policy.h> #include <primitives/transaction.h> -#include <rpc/server.h> -#include <scheduler.h> #include <script/ismine.h> #include <script/standard.h> #include <support/allocators/secure.h> #include <sync.h> -#include <timedata.h> #include <ui_interface.h> #include <uint256.h> #include <util/system.h> -#include <validation.h> #include <wallet/feebumper.h> #include <wallet/fees.h> #include <wallet/rpcwallet.h> |