diff options
| author | fanquake <fanquake@gmail.com> | 2021-09-16 08:23:04 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-09-16 08:47:38 +0800 |
| commit | 528e08119fd837dfe73d80d0064409ac03b3bfee (patch) | |
| tree | 1fc7829920298294639b0375f3ce36c7bab5591c /src/interfaces | |
| parent | 2161a058552ac938f2079b311a2d12f5d1772d01 (diff) | |
| parent | e4709c7b56612553fb7cbf16ef2d5099c5b732d0 (diff) | |
Merge bitcoin/bitcoin#22219: multiprocess: Start using init makeNode, makeChain, etc methods
e4709c7b56612553fb7cbf16ef2d5099c5b732d0 Start using init makeNode, makeChain, etc methods (Russell Yanofsky)
Pull request description:
Use `interfaces::Init::make*` methods instead of `interfaces::Make*` functions, so interfaces can be constructed differently in different executable without having to change any code. (So for example `bitcoin-gui` can make an `interfaces::Node` pointer that communicates with a `bitcoin-node` subprocess, while `bitcoin-qt` can make an `interfaces::Node` pointer that controls node code in the same process.)
---
This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10). The commit was first part of larger PR #10102.
ACKs for top commit:
jamesob:
reACK https://github.com/bitcoin/bitcoin/commit/e4709c7b56612553fb7cbf16ef2d5099c5b732d0
achow101:
ACK e4709c7b56612553fb7cbf16ef2d5099c5b732d0
benthecarman:
utACK e4709c7b56612553fb7cbf16ef2d5099c5b732d0
Tree-SHA512: 580c1979dbb2ef444157c8e53041e70d15ddeee77e5cbdb34f70b6d228cc2d2fe3843825f172da84e506200c58f7e0932f7cd4c006bb5058c1f4e43259394834
Diffstat (limited to 'src/interfaces')
| -rw-r--r-- | src/interfaces/node.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/interfaces/node.h b/src/interfaces/node.h index 77129423db..770b1b8753 100644 --- a/src/interfaces/node.h +++ b/src/interfaces/node.h @@ -230,7 +230,7 @@ public: }; //! Return implementation of Node interface. -std::unique_ptr<Node> MakeNode(NodeContext* context = nullptr); +std::unique_ptr<Node> MakeNode(NodeContext& context); //! Block tip (could be a header or not, depends on the subscribed signal). struct BlockTip { |