diff options
| author | John Newbery <john@johnnewbery.com> | 2019-04-03 17:55:24 -0400 |
|---|---|---|
| committer | John Newbery <john@johnnewbery.com> | 2019-10-18 09:26:32 -0400 |
| commit | d1734f9a3b138ab046f38ee44a09bc3847bf938a (patch) | |
| tree | 172eb76ab4c70e926fe292d8e535cae48ee879fc /src/interfaces/wallet.h | |
| parent | b6f486a02b463ffeaf82ec11fc6f74f439c037ae (diff) | |
| download | bitcoin-d1734f9a3b138ab046f38ee44a09bc3847bf938a.tar.xz | |
[wallet] Remove return value from CommitTransaction()
CommitTransaction returns a bool to indicate success, but since commit
b3a74100b8 it only returns true, even if the transaction was not
successfully broadcast. This commit changes CommitTransaction() to return
void.
All dead code in `if (!CommitTransaction())` branches has been removed.
Diffstat (limited to 'src/interfaces/wallet.h')
| -rw-r--r-- | src/interfaces/wallet.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/interfaces/wallet.h b/src/interfaces/wallet.h index 89e056b18b..a96b93b4c3 100644 --- a/src/interfaces/wallet.h +++ b/src/interfaces/wallet.h @@ -141,10 +141,9 @@ public: std::string& fail_reason) = 0; //! Commit transaction. - virtual bool commitTransaction(CTransactionRef tx, + virtual void commitTransaction(CTransactionRef tx, WalletValueMap value_map, - WalletOrderForm order_form, - std::string& reject_reason) = 0; + WalletOrderForm order_form) = 0; //! Return whether transaction can be abandoned. virtual bool transactionCanBeAbandoned(const uint256& txid) = 0; |