diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-12-23 15:16:24 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-12-23 15:16:31 +0100 |
| commit | f7367b88e1c2cf1feca4d49f49b9616a5ad85a44 (patch) | |
| tree | 7309d86ed2cd0793e7f8b7912bcf6c1ba30888b1 /src/init/bitcoind.cpp | |
| parent | f5c678e5c3f013520078768027cc8ff860a15279 (diff) | |
| parent | ff5f6dea5336075d1a6cace1112be3252d97540b (diff) | |
| download | bitcoin-f7367b88e1c2cf1feca4d49f49b9616a5ad85a44.tar.xz | |
Merge bitcoin/bitcoin#23842: scripted-diff: Rename interfaces::WalletClient to interfaces::WalletLoader
ff5f6dea5336075d1a6cace1112be3252d97540b scripted-diff: Rename interfaces::WalletClient to interfaces::WalletLoader (Russell Yanofsky)
Pull request description:
Name has been confusing since it was introduced, and it was pointed in recent review club https://bitcoincore.reviews/10102 that it was particularly unclear how `interfaces::WalletClient` was different from `interfaces::Wallet`.
ACKs for top commit:
w0xlt:
ACK ff5f6de
Tree-SHA512: 26fa10baa457e76da1933adab187e9be61b8d76cff1cf2c73ad4320461c7e31fb9db07b7c2486998294826beb4a1aca255c14903920b443db6213e653c5f7e0a
Diffstat (limited to 'src/init/bitcoind.cpp')
| -rw-r--r-- | src/init/bitcoind.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/init/bitcoind.cpp b/src/init/bitcoind.cpp index 9c8d5bd9bb..9c2e44569a 100644 --- a/src/init/bitcoind.cpp +++ b/src/init/bitcoind.cpp @@ -24,9 +24,9 @@ public: } std::unique_ptr<interfaces::Node> makeNode() override { return interfaces::MakeNode(m_node); } std::unique_ptr<interfaces::Chain> makeChain() override { return interfaces::MakeChain(m_node); } - std::unique_ptr<interfaces::WalletClient> makeWalletClient(interfaces::Chain& chain) override + std::unique_ptr<interfaces::WalletLoader> makeWalletLoader(interfaces::Chain& chain) override { - return MakeWalletClient(chain, *Assert(m_node.args)); + return MakeWalletLoader(chain, *Assert(m_node.args)); } std::unique_ptr<interfaces::Echo> makeEcho() override { return interfaces::MakeEcho(); } NodeContext& m_node; |