diff options
| author | fanquake <fanquake@gmail.com> | 2022-05-27 15:54:21 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2022-05-28 09:43:02 +0100 |
| commit | cc61bc2e19b1c8cb32778ef42746d32b02cc2671 (patch) | |
| tree | c6ee2e9549c984ade738369ef96f7bb5cc209f2d /src/init.h | |
| parent | ba48fcf4a40c5b9888459511fb4233a1b89184cc (diff) | |
compat: remove glibcxx sanity checks
These checks were added in #4339, (see also #4081), to test
our back-compat stubs, however, those stubs no-longer exist (#22930),
meaning that these checks are now just testing some specific standard
library behaviour, without a particular rationale, or reason, compared
to any other standard library functions we use.
There has also been some discussion about the sanity checks in the
context of the libbitcoinkernel refactoring, see
https://github.com/bitcoin/bitcoin/pull/25065#discussion_r880668218.
Removing the checks removes the need to worry about atleast the glibcxx
checks.
Also remove the list of check from the doc in init.h, because it is
incomplete, and anyone who wants to know what checks are included can
look at the function.
Diffstat (limited to 'src/init.h')
| -rw-r--r-- | src/init.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/init.h b/src/init.h index 2250ae20a0..1e22771dc2 100644 --- a/src/init.h +++ b/src/init.h @@ -43,7 +43,7 @@ bool AppInitBasicSetup(const ArgsManager& args); */ bool AppInitParameterInteraction(const ArgsManager& args, bool use_syscall_sandbox = true); /** - * Initialization sanity checks: ecc init, sanity checks, dir lock. + * Initialization sanity checks. * @note This can be done before daemonization. Do not call Shutdown() if this function fails. * @pre Parameters should be parsed and config file should be read, AppInitParameterInteraction should have been called. */ |