diff options
| author | fanquake <fanquake@gmail.com> | 2020-08-24 21:28:02 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-08-24 21:50:37 +0800 |
| commit | 4fefd80f08880abd7c2d77a170152a9ef4394e4a (patch) | |
| tree | 44702f65d41a7efd17c740529490f01b7e216069 /src/init.cpp | |
| parent | 7ce7f2b2518cfa3bd4102c5b443278379bbf24eb (diff) | |
| parent | daed542a12e0a6a4692aca12a61b84cd55accc33 (diff) | |
| download | bitcoin-4fefd80f08880abd7c2d77a170152a9ef4394e4a.tar.xz | |
Merge #19704: Net processing: move ProcessMessage() to PeerLogicValidation
daed542a12e0a6a4692aca12a61b84cd55accc33 [net_processing] Move ProcessMessage to PeerLogicValidation (John Newbery)
c556770b5ef4306f10e980daff772bee87daaa30 [net_processing] Change PeerLogicValidation to hold a connman reference (John Newbery)
Pull request description:
Rather than ProcessMessage() being a static function in net_processing.cpp, make it a private member function of PeerLogicValidation. This is the start of moving static functions and global variables into PeerLogicValidation to make it better encapsulated.
ACKs for top commit:
jonatack:
ACK daed542a12e0a6a4692aca12a61b84cd55accc33 code review and debug tested
promag:
Code review ACK daed542a12e0a6a4692aca12a61b84cd55accc33.
MarcoFalke:
re-ACK daed542a12, only change is removing second commit 🎴
theStack:
Code Review ACK daed542a12e0a6a4692aca12a61b84cd55accc33
Tree-SHA512: ddebf410d114d9ad5a9e536950018ff333a347c035d74fcc101fb4a3f20a281782c7eac2b7d1bd1c8f6bc7e59f5b5630fb52c2e1b4c32df454fa584673bd021e
Diffstat (limited to 'src/init.cpp')
| -rw-r--r-- | src/init.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/init.cpp b/src/init.cpp index f5aef08211..ebea6037d6 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -1387,7 +1387,7 @@ bool AppInitMain(const util::Ref& context, NodeContext& node, interfaces::BlockA node.chainman = &g_chainman; ChainstateManager& chainman = *Assert(node.chainman); - node.peer_logic.reset(new PeerLogicValidation(node.connman.get(), node.banman.get(), *node.scheduler, chainman, *node.mempool)); + node.peer_logic.reset(new PeerLogicValidation(*node.connman, node.banman.get(), *node.scheduler, chainman, *node.mempool)); RegisterValidationInterface(node.peer_logic.get()); // sanitize comments per BIP-0014, format user agent and check total size |