diff options
author | fanquake <fanquake@gmail.com> | 2023-01-31 17:55:37 +0000 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2023-01-31 17:55:44 +0000 |
commit | b5868f4b1f884e8d6612f34ca4005fe3a992053d (patch) | |
tree | 324c22d1bbcb5c6d2c9331f3b21f7046473d8765 /src/index | |
parent | 1ff254e45cba1dcf182be5a87c26adb2ecd1c237 (diff) | |
parent | 6d58117a31a88eec3f0a103f9d1fc26cf0b48348 (diff) | |
download | bitcoin-b5868f4b1f884e8d6612f34ca4005fe3a992053d.tar.xz |
Merge bitcoin/bitcoin#23670: build: Build minisketch test in `make check`, not in `make`
6d58117a31a88eec3f0a103f9d1fc26cf0b48348 build: Build minisketch test in `make check`, not in `make` (Hennadii Stepanov)
Pull request description:
On master (d1e42659bbdd8da170542d8c638242cd94f71a7d):
```
$ ./autogen.sh && ./configure --without-gui --disable-wallet && make clean
$ make 2>&1 | grep LD | grep -v .la
CXXLD bitcoind
CXXLD bitcoin-cli
CXXLD bitcoin-tx
CXXLD bitcoin-util
CXXLD test/test_bitcoin
CXXLD bench/bench_bitcoin
CXXLD minisketch/test
CXXLD test/fuzz/fuzz
CXXLD univalue/test/object
CXXLD univalue/test/unitester
$ make check 2>&1 | grep LD
CCLD exhaustive_tests
CCLD tests
```
With this PR:
```
$ ./autogen.sh && ./configure --without-gui --disable-wallet && make clean
$ make 2>&1 | grep LD | grep -v .la
CXXLD bitcoind
CXXLD bitcoin-cli
CXXLD bitcoin-tx
CXXLD bitcoin-util
CXXLD test/test_bitcoin
CXXLD bench/bench_bitcoin
CXXLD test/fuzz/fuzz
CXXLD univalue/test/object
CXXLD univalue/test/unitester
$ make check 2>&1 | grep LD
CXXLD minisketch/test
CCLD exhaustive_tests
CCLD tests
```
In fact, this PR restores behavior that was before bitcoin/bitcoin#22646, and that behavior looks more optimal.
As an outcome, the `contrib/guix/libexec/build.sh` does not spend resources to build binaries which are not a part of the release package.
ACKs for top commit:
TheCharlatan:
ACK 6d58117a31a88eec3f0a103f9d1fc26cf0b48348
Tree-SHA512: 4957c8f88a01aca005813bf4c1c26f433756bf68ea0c958481c638ead229fa8e23ecae3a8ac31ea555876ba6f2cc10ecd91caf2e2f664de5cb529ec05fb38fa7
Diffstat (limited to 'src/index')
0 files changed, 0 insertions, 0 deletions