diff options
| author | fanquake <fanquake@gmail.com> | 2020-08-20 09:35:59 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-08-20 10:17:14 +0800 |
| commit | 70d7ddbcbbead05031f6071adaf6dd2e183ab4f9 (patch) | |
| tree | b1aef050cca274f41acfdd69f62c0e08ce49028a /src/index | |
| parent | 44f66d2f10cb9ba0538c836976bdd090fd38c8f0 (diff) | |
| parent | ed5cd12869e0691a785199d2d977ce5879095180 (diff) | |
| download | bitcoin-70d7ddbcbbead05031f6071adaf6dd2e183ab4f9.tar.xz | |
Merge #19727: test: Remove unused classes from p2p_leak.py
ed5cd12869e0691a785199d2d977ce5879095180 test: Distinguish between nodes(bitcoind) and peers(mininodes) in p2p_leak.py (Dhruv Mehta)
f6f082b9343522bc8005f23937ac6ecf56548c98 test: remove `CNodeNoVersionIdle` from p2p_leak.py (Dhruv Mehta)
45cf55ccac94689e48dd0648ed2401918a778024 test: remove `CNodeNoVersionMisbehavior` from p2p_leak.py (Dhruv Mehta)
Pull request description:
- Removes `CNodeNoVersionMisbehavior` per recommendation at https://github.com/bitcoin/bitcoin/pull/19657#issuecomment-669926458
- Removes `CNodeNoVersionIdle` because it is similarly unnecessary
- As someone new to the codebase, I found it easier to understand it if `no_version_disconnect_node` tries to overwhelm the peer with any message that is not version/verack.
- Per recommendation at https://github.com/bitcoin/bitcoin/pull/19727#pullrequestreview-468093555, made a clear distinction between nodes(bitcoind) and peers(mininode interface implementations)
ACKs for top commit:
jnewbery:
tested ACK ed5cd12869e0691a785199d2d977ce5879095180
amitiuttarwar:
utACK ed5cd12869
Tree-SHA512: 310a24c91fd837e7f65177edb55fe6142fb3559fae7867c5cdd9c9a23b1a02202b935ca9a82633fa7649f3de2fa221f6da906a7b5e499fc20f7254085033757d
Diffstat (limited to 'src/index')
0 files changed, 0 insertions, 0 deletions