diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-03-10 08:24:47 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-03-10 08:24:53 +0100 |
| commit | eea6196c3d8056e51e1780a44ac7f599331247e5 (patch) | |
| tree | 4ab283e8c2ef5be123b46a6607380f5e63460b6a /src/i2p.h | |
| parent | ceb6df391f281aa038ed8da6f19cad39d0d7d92e (diff) | |
| parent | 7c90c67b7e6f598f9ffdc136ded2b533b78ed044 (diff) | |
| download | bitcoin-eea6196c3d8056e51e1780a44ac7f599331247e5.tar.xz | |
Merge #21331: rpc: replace wallet raw pointers with references (#18592 rebased)
7c90c67b7e6f598f9ffdc136ded2b533b78ed044 rpc: refactor rpc wallet functions to take references instead of pointers (fanquake)
48669340080feaff86b8fc0403ef22c820477697 rpc: remove calls to CWallet.get() (fanquake)
Pull request description:
This is a rebased #18592.
> This PR replaces raw pointers in `rpcwallet.cpp` and `rpcdump.cpp` with **shared_ptr**. The motivation for this PR is described here https://github.com/bitcoin/bitcoin/issues/18590
> It seems that this PR is indirectly related to this issue: https://github.com/bitcoin/bitcoin/pull/13063#discussion_r186740049
> Notice: I have deliberately **not** changed the class `WalletRescanReserver ` whose constructor expects a raw pointer, because it's external and affects other areas, which I didn't touch to avoid making this PR "viral".
> Fixes https://github.com/bitcoin/bitcoin/issues/18590
ACKs for top commit:
MarcoFalke:
ACK 7c90c67b7e6f598f9ffdc136ded2b533b78ed044 🐧
ryanofsky:
Code review ACK 7c90c67b7e6f598f9ffdc136ded2b533b78ed044. Changes easy to review with `--word-diff-regex=. -U0`
Tree-SHA512: 32d69c813026b02260e8a89de9d6a5ab9e87826ba230687246583ac7a80c8c3fd00318da4658f1450e04c23d2c77ae765862de0d2a110b1312b3b69a1161e7ba
Diffstat (limited to 'src/i2p.h')
0 files changed, 0 insertions, 0 deletions