diff options
author | MarcoFalke <falke.marco@gmail.com> | 2019-12-16 10:15:51 -0500 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2019-12-16 10:17:17 -0500 |
commit | 6b51cce65afd9a6357277c4339d7cf56814e476e (patch) | |
tree | 0455fe615a2033d89cc1f2608869aaeb4155919f /src/httpserver.cpp | |
parent | 5e4912f99096e9955b332df004662f83885b322f (diff) | |
parent | 137c80d579502e329964d7d1028a9507d4667774 (diff) | |
download | bitcoin-6b51cce65afd9a6357277c4339d7cf56814e476e.tar.xz |
Merge #17753: util: Don't allow Base32/64-decoding or ParseMoney(…) on strings with embedded NUL characters. Add tests.
137c80d579502e329964d7d1028a9507d4667774 tests: Add tests for decoding/parsing of base32, base64 and money strings containing NUL characters (practicalswift)
a6fc26da55dea3b76bd89fbbca24ded170238674 util: Don't allow DecodeBase32(...) of strings with embedded NUL characters (practicalswift)
93cc18b0f6fa5fa8144079a4f51904d8b3087e94 util: Don't allow DecodeBase64(...) of strings with embedded NUL characters (practicalswift)
ccc53e43c5464058171d6291da861a88184b230e util: Don't allow ParseMoney(...) of strings with embedded NUL characters (practicalswift)
Pull request description:
Don't allow Base32/64-decoding or `ParseMoney(…)` on strings with embedded `NUL` characters. Add tests.
Added tests before:
```
$ src/test/test_bitcoin
Running 385 test cases...
test/base32_tests.cpp(31): error: in "base32_tests/base32_testvectors":
check failure == true has failed [false != true]
test/base64_tests.cpp(31): error: in "base64_tests/base64_testvectors":
check failure == true has failed [false != true]
test/util_tests.cpp(1074): error: in "util_tests/util_ParseMoney":
check !ParseMoney(std::string("\0-1", 3), ret) has failed
test/util_tests.cpp(1076): error: in "util_tests/util_ParseMoney":
check !ParseMoney(std::string("1\0", 2), ret) has failed
*** 4 failures are detected in the test module "Bitcoin Core Test Suite"
```
Added tests after:
```
$ src/test/test_bitcoin
Running 385 test cases...
*** No errors detected
```
ACKs for top commit:
laanwj:
Code review ACK 137c80d579502e329964d7d1028a9507d4667774
Tree-SHA512: 9486a0d32b4cf686bf5a47a0778338ac571fa39c66ad6d6d6cede58ec798e87bb50a2f9b7fd79ecd1fef1ba284e4073c1b430110967073ff87bdbbde7cada447
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions