diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-08-31 14:59:36 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-08-31 15:00:15 +0200 |
| commit | 709a15b0a6f8ca421b6bb1fcb31c58fd7d7e3b68 (patch) | |
| tree | 269b0226cc4365a1d0e69b15bdc21a5f5ac89251 /src/httpserver.cpp | |
| parent | bdbd654df8ddf5945256f2ccf85feae620f6f0d5 (diff) | |
| parent | ca1a093127c11bb2aea10bf96c38dbfb40f8d170 (diff) | |
| download | bitcoin-709a15b0a6f8ca421b6bb1fcb31c58fd7d7e3b68.tar.xz | |
Merge #14088: tests: Don't assert(...) with side effects
ca1a093127c11bb2aea10bf96c38dbfb40f8d170 Add regression test: Don't assert(...) with side effects (practicalswift)
4c3c9c38699360f93d3c52a01a90ff15ee5e1a62 Don't assert(...) with side effects (practicalswift)
Pull request description:
Don't `assert(...)` with side effects.
From the developer notes:
> **Assertions should not have side-effects**
>
> Rationale: Even though the source code is set to refuse to compile with assertions disabled, having side-effects in assertions is unexpected and makes the code harder to understand
These assertions were introduced quite recently (in #14069 which was merged two days ago) and since this is a recurring thing (see #13534 – "Don't assert(foo()) where foo() has side effects" from May) I added a simple regression test for the most obvious common side effect.
Tree-SHA512: be65db9d8d5d0f5752152ba73fe3fbb0531880f156d3cd7dfdf1752709979b63214e46ae64b1adbe1e09fa121278f4087f4ae49bff16cf8f5aec16ea6bde3650
Diffstat (limited to 'src/httpserver.cpp')
0 files changed, 0 insertions, 0 deletions