aboutsummaryrefslogtreecommitdiff
path: root/src/external_signer.cpp
diff options
context:
space:
mode:
authorfanquake <fanquake@gmail.com>2021-04-13 15:18:20 +0800
committerfanquake <fanquake@gmail.com>2021-04-13 20:09:33 +0800
commit06a0673351282fff1673f3679a7cad9a7faaf987 (patch)
treef2832109fad1d434d8fdf05a6dcf5c3bbd0698f9 /src/external_signer.cpp
parent8fdbb899b84a2be85e632e45f08b222db02395d9 (diff)
downloadbitcoin-06a0673351282fff1673f3679a7cad9a7faaf987.tar.xz
external_signer: remove ignore_errors from Enumerate()
This is undocumented and unused.
Diffstat (limited to 'src/external_signer.cpp')
-rw-r--r--src/external_signer.cpp5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/external_signer.cpp b/src/external_signer.cpp
index 9278d07f49..4809c5abf2 100644
--- a/src/external_signer.cpp
+++ b/src/external_signer.cpp
@@ -21,19 +21,17 @@ const std::string ExternalSigner::NetworkArg() const
return " --chain " + m_chain;
}
-bool ExternalSigner::Enumerate(const std::string& command, std::vector<ExternalSigner>& signers, std::string chain, bool ignore_errors)
+bool ExternalSigner::Enumerate(const std::string& command, std::vector<ExternalSigner>& signers, std::string chain)
{
// Call <command> enumerate
const UniValue result = RunCommandParseJSON(command + " enumerate");
if (!result.isArray()) {
- if (ignore_errors) return false;
throw ExternalSignerException(strprintf("'%s' received invalid response, expected array of signers", command));
}
for (UniValue signer : result.getValues()) {
// Check for error
const UniValue& error = find_value(signer, "error");
if (!error.isNull()) {
- if (ignore_errors) return false;
if (!error.isStr()) {
throw ExternalSignerException(strprintf("'%s' error", command));
}
@@ -42,7 +40,6 @@ bool ExternalSigner::Enumerate(const std::string& command, std::vector<ExternalS
// Check if fingerprint is present
const UniValue& fingerprint = find_value(signer, "fingerprint");
if (fingerprint.isNull()) {
- if (ignore_errors) return false;
throw ExternalSignerException(strprintf("'%s' received invalid response, missing signer fingerprint", command));
}
std::string fingerprintStr = fingerprint.get_str();