aboutsummaryrefslogtreecommitdiff
path: root/src/external_signer.cpp
diff options
context:
space:
mode:
authorfanquake <fanquake@gmail.com>2021-04-13 19:55:59 +0800
committerfanquake <fanquake@gmail.com>2021-04-13 20:09:34 +0800
commitc8f469c6d50a8db6d92f0aed47a5d1cc82f30f7f (patch)
tree1a837e6e83ada96dfff569be2a6c31c38c80eeca /src/external_signer.cpp
parent9e0b199b976617edeb1c58d4203df5f83a26c1e3 (diff)
downloadbitcoin-c8f469c6d50a8db6d92f0aed47a5d1cc82f30f7f.tar.xz
external_signer: remove ExternalSignerException
It's not clear why this need it's own exception class, as opposed to just throwing std::runtime_error().
Diffstat (limited to 'src/external_signer.cpp')
-rw-r--r--src/external_signer.cpp9
1 files changed, 5 insertions, 4 deletions
diff --git a/src/external_signer.cpp b/src/external_signer.cpp
index 9325daeab2..f16d21fa60 100644
--- a/src/external_signer.cpp
+++ b/src/external_signer.cpp
@@ -9,6 +9,7 @@
#include <util/system.h>
#include <external_signer.h>
+#include <stdexcept>
#include <string>
#include <vector>
@@ -26,21 +27,21 @@ bool ExternalSigner::Enumerate(const std::string& command, std::vector<ExternalS
// Call <command> enumerate
const UniValue result = RunCommandParseJSON(command + " enumerate");
if (!result.isArray()) {
- throw ExternalSignerException(strprintf("'%s' received invalid response, expected array of signers", command));
+ throw std::runtime_error(strprintf("'%s' received invalid response, expected array of signers", command));
}
for (UniValue signer : result.getValues()) {
// Check for error
const UniValue& error = find_value(signer, "error");
if (!error.isNull()) {
if (!error.isStr()) {
- throw ExternalSignerException(strprintf("'%s' error", command));
+ throw std::runtime_error(strprintf("'%s' error", command));
}
- throw ExternalSignerException(strprintf("'%s' error: %s", command, error.getValStr()));
+ throw std::runtime_error(strprintf("'%s' error: %s", command, error.getValStr()));
}
// Check if fingerprint is present
const UniValue& fingerprint = find_value(signer, "fingerprint");
if (fingerprint.isNull()) {
- throw ExternalSignerException(strprintf("'%s' received invalid response, missing signer fingerprint", command));
+ throw std::runtime_error(strprintf("'%s' received invalid response, missing signer fingerprint", command));
}
const std::string fingerprintStr = fingerprint.get_str();
// Skip duplicate signer