diff options
author | MarcoFalke <falke.marco@gmail.com> | 2022-02-15 19:57:17 +0100 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2022-02-15 19:57:25 +0100 |
commit | 1e8aa02ec5cc2819c67ef40a7573c4b23a4c11cc (patch) | |
tree | 64497ba343022aeeb40c33be71cc7db4cadc80d9 /src/crypto | |
parent | 7164e00e1bc4e30e69b38a7ba9c557d4fc5d5f87 (diff) | |
parent | bfcd60f5d505334230013de4115483b22a7898ee (diff) | |
download | bitcoin-1e8aa02ec5cc2819c67ef40a7573c4b23a4c11cc.tar.xz |
Merge bitcoin/bitcoin#24117: index: make indices robust against init aborts
bfcd60f5d505334230013de4115483b22a7898ee test: activate all index types in feature_init.py (Martin Zumsande)
0243907faee0aa6af09974131d9a46a7f9c3ef38 index: Don't commit without valid m_best_block_index (Martin Zumsande)
Pull request description:
When an index thread receives an interrupt during init before it got to index anything (so `m_best_block_index == nullptr` still), it will still try to commit previous "work" before stopping the thread. That means that `BaseIndex::CommitInternal()` calls `GetLocator(nullptr)`, which returns an locator to the tip ([code](https://github.com/bitcoin/bitcoin/blob/06b6369766137756648b3cb62c8f385cca234e69/src/chain.cpp#L31-L32)), and saves it to the index DB.
On the next startup, this locator will be read and it will be assumed that we have successfully synced the index to the tip, when in reality we have indexed nothing.
In the case of coinstatsindex, this would lead to a shutdown of bitcoind without any indication what went wrong. For the other indexes, there would be no immediate shutdown, but the index would be corrupt.
This PR fixes this by not committing when `m_best_block_index==nullptr`, and it also adds an error log message to the silent coinstatsindex shutdown path.
This is another small bug found by `feature_init.py` - the second commit enables blockfilterindex and coinstatsindex for this test, enabling coinstatsindex without the first commit would have led to frequent failures.
ACKs for top commit:
fjahr:
reACK bfcd60f5d505334230013de4115483b22a7898ee
shaavan:
reACK bfcd60f5d505334230013de4115483b22a7898ee
Tree-SHA512: 8e2bac0fc40cde209518a9e59b597ae0a5a875a2a90898673987c91733718d40e528dada942bf552b58bc021bf46e59da2d0cc5a61045f48f9bae2b1baf6033b
Diffstat (limited to 'src/crypto')
0 files changed, 0 insertions, 0 deletions