aboutsummaryrefslogtreecommitdiff
path: root/src/core_write.cpp
diff options
context:
space:
mode:
authorGregory Maxwell <greg@xiph.org>2017-06-17 00:18:42 +0000
committerGregory Maxwell <greg@xiph.org>2017-07-14 19:24:17 +0000
commit3babbcb48786372d4b22171674c4cc5a6220c294 (patch)
tree099fab1403b69a6da62d222fbf8b2d45f0c12fa7 /src/core_write.cpp
parente4fcbf797ed3b472d352ac3794ec82f581209c50 (diff)
downloadbitcoin-3babbcb48786372d4b22171674c4cc5a6220c294.tar.xz
Remove confusing MAX_BLOCK_BASE_SIZE.
Some people keep thinking that MAX_BLOCK_BASE_SIZE is a separate size limit from the weight limit when it fact it is superfluous, and used in early tests before the witness data has been validated or just to compute worst case sizes. The size checks that use it would not behave any differently consensus wise if they were eliminated completely. Its correct value is not independently settable but is a function of the weight limit and weight formula. This patch just eliminates it and uses the scale factor as required to compute the worse case constants. It also moves the weight factor out of primitives into consensus, which is a more logical place for it.
Diffstat (limited to 'src/core_write.cpp')
-rw-r--r--src/core_write.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/core_write.cpp b/src/core_write.cpp
index 7f38e9e565..a366ef933c 100644
--- a/src/core_write.cpp
+++ b/src/core_write.cpp
@@ -5,7 +5,8 @@
#include "core_io.h"
#include "base58.h"
-#include "primitives/transaction.h"
+#include "consensus/consensus.h"
+#include "consensus/validation.h"
#include "script/script.h"
#include "script/standard.h"
#include "serialize.h"
@@ -15,7 +16,6 @@
#include "utilmoneystr.h"
#include "utilstrencodings.h"
-
std::string FormatScript(const CScript& script)
{
std::string ret;