diff options
| author | Andrew Chow <achow101-github@achow101.com> | 2022-05-26 13:07:38 -0400 |
|---|---|---|
| committer | Andrew Chow <achow101-github@achow101.com> | 2022-05-26 13:49:52 -0400 |
| commit | a0e8aff6051bfeaad38799058a2a46fa2e45911d (patch) | |
| tree | 1747a0504edb68375eb6c7e4cdffc30673f22e32 /src/consensus | |
| parent | 2642dee1364ddc9b174e0ccb6b7b37ae44899c2a (diff) | |
| parent | 6b636730f4befee39d57fcfd51298f3015dbf563 (diff) | |
| download | bitcoin-a0e8aff6051bfeaad38799058a2a46fa2e45911d.tar.xz | |
Merge bitcoin/bitcoin#25003: tracing: fix `coin_selection:aps_create_tx_internal` calling logic
6b636730f4befee39d57fcfd51298f3015dbf563 tracing: fix `coin_selection:aps_create_tx_internal` calling logic (Sebastian Falbesoner)
Pull request description:
According to the documentation, the tracepoint `coin_selection:aps_create_tx_internal` "Is called when the second `CreateTransactionInternal` with Avoid Partial Spends enabled completes."
Currently it is only called if the second call to `CreateTransactionInternal` succeeds, i.e. the third parameter is always `true` and we don't get notified in the case that it fails. This PR fixes this by moving the tracepoint call and the `use_aps` boolean variable outside the if body.
ACKs for top commit:
achow101:
ACK 6b636730f4befee39d57fcfd51298f3015dbf563
furszy:
re-ACK 6b636730
Tree-SHA512: 453825123aa10748642c7dd94324ced2d07df0f4fac478b0947a34820b515ae300f75721679a90a164f3127029739df55c4de035c4567e663893c3c6dbdef216
Diffstat (limited to 'src/consensus')
0 files changed, 0 insertions, 0 deletions