diff options
| author | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2021-08-11 22:26:55 +0300 |
|---|---|---|
| committer | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2021-08-11 22:29:31 +0300 |
| commit | e614cc8cd808902c843568f1790730622d619620 (patch) | |
| tree | 3ee34a28f56af78de444cbb8aa8c18ca18f807e2 /src/clientversion.cpp | |
| parent | 77e23ca945030d557559a7391cb8bd368693548c (diff) | |
| parent | 0237d95323dec7c65b7223c314afdf63aab6b11b (diff) | |
| download | bitcoin-e614cc8cd808902c843568f1790730622d619620.tar.xz | |
Merge bitcoin-core/gui#399: Fix "Load PSBT" functionality when no wallet loaded
0237d95323dec7c65b7223c314afdf63aab6b11b qt: Add Load PSBT functionaliy with nowallet (Prateek Sancheti)
Pull request description:
This PR provides a fix to the issue mentioned in #232.
Currently, the **_Load PSBT_** functionality works well in case a wallet is loaded but does nothing when a wallet isn't loaded.
If a function cannot work without a wallet being loaded, it is disabled by default (It is unclickable as shown in the image).
For e.g. One cannot `Close Wallet` or `Backup Wallet` or `Sign Messages` without a wallet being loaded. And hence they are disabled. But if you notice, `Load PSBT` options are not disabled by default even when a wallet isn't loaded.
> 
As mentioned by hebasto in the issue description :
```
<hebasto> achow101: does "File" -> "Load PSBT from {file|clipboard}" make any sense when no wallet is loaded?
<achow101> hebasto: yes, for finalize and sending
```
This means **_Load PSBT_** should be working just as similar whether wallets are being loaded or not.
After making the required changes to the code, The **_Load PSBT_** works as expected even with no wallet loaded and the PSBT is finalized.
| Master | PR |
|-------------|---------------|
|  |  |
Close #232
ACKs for top commit:
achow101:
re-ACK 0237d95323dec7c65b7223c314afdf63aab6b11b
hebasto:
ACK 0237d95323dec7c65b7223c314afdf63aab6b11b, tested on Linux Mint 20.2 (Qt 5.12.8).
Tree-SHA512: 8d928c5bfd3c2b286ddcacd0b367c872de8bc3d3d9d82280faeadc60d738b86af328c060b5763ade364c9b386b23f95580c2eb1147b16373fbb713170c100350
Diffstat (limited to 'src/clientversion.cpp')
0 files changed, 0 insertions, 0 deletions