diff options
| author | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-07-19 10:05:51 +0100 |
|---|---|---|
| committer | Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> | 2022-07-19 10:18:46 +0100 |
| commit | 6d8707b21d3a5b4abb76b773a69f2bfac22bcd93 (patch) | |
| tree | 42539930bd7e5c4826c00532630d2bdd3c0db5b8 /src/chainparamsbase.h | |
| parent | 1b285b7807076b9b9c2863c27776c5f1354c1f5b (diff) | |
| parent | 4c495413e138ec1dd6874e41b44e689f0c15e0e3 (diff) | |
Merge bitcoin-core/gui#631: Disallow encryption of watchonly wallets
4c495413e138ec1dd6874e41b44e689f0c15e0e3 Disallow encryption of watchonly wallets (Andrew Chow)
Pull request description:
Watchonly wallets do not have any private keys to encrypt. It does not make sense to encrypt such wallets, so disable the option to encrypt them.
This avoids an assertion that can be hit when encrypting watchonly descriptor wallets.
As our current behavior allows for encrypting watchonly wallets (no crash with legacy, crash, but still encrypted with descriptors), the new `NoKeys` status is only returned for unencrypted watchonly wallets. This allows any watchonly wallets that were previously encrypted to show the correct encryption status (they have encryption keys, and so should be indicated as being encrypted).
ACKs for top commit:
w0xlt:
tACK https://github.com/bitcoin-core/gui/pull/631/commits/4c495413e138ec1dd6874e41b44e689f0c15e0e3
hebasto:
ACK 4c495413e138ec1dd6874e41b44e689f0c15e0e3, tested on Ubuntu 22.04.
Tree-SHA512: 054dba0a8c1343a0df17689508cd628a974555828955a3c8820bf020868b95a3df98c47253b0ffe2252765b020160bb76ea21647d76d59ba748b3b41c481f2ae
Diffstat (limited to 'src/chainparamsbase.h')
0 files changed, 0 insertions, 0 deletions