diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-08-05 09:40:46 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-08-05 09:40:52 +0200 |
| commit | 7d60f7ec6bbf293c6f23f442a0fd985111a15ff7 (patch) | |
| tree | c47cd88761c02f65feba88de7052870d942d87a1 /src/chainparams.cpp | |
| parent | dd981b5e840c0f1b29e8adaaea285230efd0aba6 (diff) | |
| parent | faa670d3862783017f5cd1491f37648e1875f19f (diff) | |
Merge bitcoin/bitcoin#22277: test: Properly set BIP34 height in CreateNewBlock_validity unit test
faa670d3862783017f5cd1491f37648e1875f19f test: Properly set BIP34 height in CreateNewBlock_validity unit test (MarcoFalke)
Pull request description:
The coinbase scriptSig in this unit test has several issues:
* The BIP34 height is not the "first item" as required (See https://github.com/bitcoin/bips/blob/master/bip-0034.mediawiki#specification)
* It uses the wrong encoding ( See https://github.com/bitcoin/bitcoin/blob/da69d9965a112c6421fce5649b5a18beb7513526/src/validation.cpp#L3250 )
* It uses the wrong height (off by one)
While BIP34 isn't currently enforced in this unit test, this should be fixed to avoid confusion and to promote self-consistency.
The change obviously requires new proof of work (`BLOCKINFO`).
Also change the block version from `1` to `VERSIONBITS_TOP_BITS`, because this test shouldn't care about the block version and bumping it is required for other changes.
ACKs for top commit:
theStack:
Code review ACK faa670d3862783017f5cd1491f37648e1875f19f
Tree-SHA512: 8dbe2d5300a640f3e1817ff048906e60463aca64ba50fec8ee4f18fb1c70e511008755b0b5baba81114a1a6265fdfae9a4b7ae8acadfb2c7ad43223157a0386c
Diffstat (limited to 'src/chainparams.cpp')
0 files changed, 0 insertions, 0 deletions