aboutsummaryrefslogtreecommitdiff
path: root/src/chain.h
diff options
context:
space:
mode:
authorJon Atack <jon@atack.com>2022-07-16 13:22:46 +0200
committerJon Atack <jon@atack.com>2022-07-22 12:42:27 +0200
commit14aeece462b149eaf0d28a37d55cc169df99b2cb (patch)
tree06650ddeffc85efe331ad49a19a1d611b5d10324 /src/chain.h
parent02ede4f1fde9b5aa3ff370d523f9c9858c98905c (diff)
downloadbitcoin-14aeece462b149eaf0d28a37d55cc169df99b2cb.tar.xz
CBlockIndex: ensure phashBlock is not nullptr before dereferencing
and remove a now-redundant assert preceding a GetBlockHash() caller. This protects against UB here, and in case of failure (which would indicate a consensus bug), the debug log will print bitcoind: chain.h:265: uint256 CBlockIndex::GetBlockHash() const: Assertion `phashBlock != nullptr' failed. Aborted instead of Segmentation fault
Diffstat (limited to 'src/chain.h')
-rw-r--r--src/chain.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/chain.h b/src/chain.h
index ecc2ae732f..1a499b07cc 100644
--- a/src/chain.h
+++ b/src/chain.h
@@ -263,6 +263,7 @@ public:
uint256 GetBlockHash() const
{
+ assert(phashBlock != nullptr);
return *phashBlock;
}