diff options
| author | fanquake <fanquake@gmail.com> | 2019-10-25 07:57:42 -0400 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-10-25 08:14:11 -0400 |
| commit | 48cb468ce3f52195dfc64c6df88b8af36b77dbb0 (patch) | |
| tree | cf2dc07157035f3bba653a900911ca081995303d /src/bitcoin-wallet.cpp | |
| parent | 37855ec9df57249b91c57484031986812f2972fd (diff) | |
| parent | 0a433fc876d82df1005f175c1254fff62f0f36f8 (diff) | |
Merge #17242: refactor: Remove unused cacheSigStore from CheckInputsFromMempooAndCache
0a433fc876d82df1005f175c1254fff62f0f36f8 [validation] Remove unused cacheSigStore from CheckInputsFromMempoolAndCache (John Newbery)
Pull request description:
CheckInputsFromMempoolAndCache() is only called in one place, and
cacheSigStore is set to true in that call site. Remove the argument
entirely.
Also improve commenting.
ACKs for top commit:
MarcoFalke:
unsigned ACK 0a433fc876d82df1005f175c1254fff62f0f36f8 Comment looks good
jamesob:
ACK https://github.com/bitcoin/bitcoin/pull/17242/commits/0a433fc876d82df1005f175c1254fff62f0f36f8
laanwj:
ACK 0a433fc876d82df1005f175c1254fff62f0f36f8
fanquake:
ACK 0a433fc876d82df1005f175c1254fff62f0f36f8. Checked that `CheckInputsFromMempoolAndCache` is only called once, in `MemPoolAccept::ConsensusScriptChecks`, and that `cacheSigStore` is true.
Tree-SHA512: e4b4d2550e35df55c8f8fa4c539174cc2d3728112ddb937cb2ff759d8630a01566b5ec42a70a82e33994e6586f5a457a75a59f64b15d27c65331c723cbb097af
Diffstat (limited to 'src/bitcoin-wallet.cpp')
0 files changed, 0 insertions, 0 deletions