diff options
| author | fanquake <fanquake@gmail.com> | 2023-09-11 09:29:40 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-09-11 09:44:38 +0100 |
| commit | 8f7b9eb8711fdb32e8bdb59d2a7462a46c7a8086 (patch) | |
| tree | e580722b499779ae14f9dd5e7b6e15d086d4aa68 /src/bitcoin-wallet.cpp | |
| parent | c5a63ea56f8347139bd84e1669b378ecfb234c3c (diff) | |
| parent | 64704386b28ce3a1ab607a946ec729286da8faa6 (diff) | |
Merge bitcoin/bitcoin#28433: Follow-up to BIP324 connection support
64704386b28ce3a1ab607a946ec729286da8faa6 doc: fix typos and mistakes in BIP324 code comments (Pieter Wuille)
9bde93df2c84b6d5f333aa56cbd0b28b6ad337b0 net: do not use send buffer to store/cache garbage (Pieter Wuille)
b6934fd03f080d437acb1fd2b665503c3d6de785 net: merge V2Transport constructors, move key gen (Pieter Wuille)
Pull request description:
This addresses a few remaining comments on #28196:
* Deduplicate the `V2Transport` constructors (https://github.com/bitcoin/bitcoin/pull/28196#discussion_r1318573111)
* Do not use the send buffer to store garbage (https://github.com/bitcoin/bitcoin/pull/28196#discussion_r1319134141)
* Fix typo (https://github.com/bitcoin/bitcoin/pull/28196#discussion_r1315179378)
In addition, also fix an incorrect description in `V2Transport::SendState` (it claimed garbage was sent in the `READY` state, but it's in the `AWAITING_KEY` state).
ACKs for top commit:
naumenkogs:
ACK 64704386b28ce3a1ab607a946ec729286da8faa6
theStack:
Code-review ACK 64704386b28ce3a1ab607a946ec729286da8faa6
Tree-SHA512: 4bf6d2fe73c8054502d0b60e9de1722f8b3dd269c2dd6bf67197c3fb6eabcf047b6360cdab3c1fd5504215c2ac4ac2890a022780efc30ff583776242c8112451
Diffstat (limited to 'src/bitcoin-wallet.cpp')
0 files changed, 0 insertions, 0 deletions