diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-10-28 13:41:45 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-10-28 13:41:45 +0100 |
| commit | f3b51eb9352d7a7c5dfa15615efc8bc0a52ffecf (patch) | |
| tree | b580be6a30428150b6ec40ca5da5bb96ee746fb1 /src/bitcoin-cli.cpp | |
| parent | a25945318fdc2890a141a28843c2c5af251c9605 (diff) | |
| download | bitcoin-f3b51eb9352d7a7c5dfa15615efc8bc0a52ffecf.tar.xz | |
Fix occurences of c_str() used with size() to data()
Using `data()` better communicates the intent here.
Also, depending on how `c_str()` is implemented, this fixes undefined
behavior: The part of the string after the first NULL character might
have undefined contents.
Diffstat (limited to 'src/bitcoin-cli.cpp')
| -rw-r--r-- | src/bitcoin-cli.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp index 93b7a7152c..a18f7bae91 100644 --- a/src/bitcoin-cli.cpp +++ b/src/bitcoin-cli.cpp @@ -366,7 +366,7 @@ static UniValue CallRPC(BaseRequestHandler *rh, const std::string& strMethod, co std::string endpoint = "/"; if (!gArgs.GetArgs("-rpcwallet").empty()) { std::string walletName = gArgs.GetArg("-rpcwallet", ""); - char *encodedURI = evhttp_uriencode(walletName.c_str(), walletName.size(), false); + char *encodedURI = evhttp_uriencode(walletName.data(), walletName.size(), false); if (encodedURI) { endpoint = "/wallet/"+ std::string(encodedURI); free(encodedURI); |