diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-04-15 17:39:32 -0400 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-04-15 17:41:56 -0400 |
commit | 544709763e1f45148d1926831e07ff03487673ee (patch) | |
tree | fab6ea4898f8670ab6e7cf415976ae5f67f13514 /src/bench/bench_bitcoin.cpp | |
parent | e84a5f000493fe39adb2a5f22b43c3848dcd0a4f (diff) | |
parent | fa69f88486e900aacf3fc768671f947927173226 (diff) | |
download | bitcoin-544709763e1f45148d1926831e07ff03487673ee.tar.xz |
Merge #18571: fuzz: Disable debug log file
fa69f88486e900aacf3fc768671f947927173226 fuzz: Disable debug log file (MarcoFalke)
fa0cbd48c418ec14e1d91bffea206bce20bd1e56 test: Add optional extra_args to testing setup (MarcoFalke)
fad4fa7e2fb95b7ced9007060ebfd0e8f181f5d8 node: Add args alias for gArgs global (MarcoFalke)
Pull request description:
There are several issues with writing to a debug log file when fuzzing:
* Disk access is slow, but fuzzing should be fast (Note: I could not verify this claim with data)
* Disks have a limited size and will eventually run out of space, but fuzzing should run continuous
Fix both issues by disabling the debug log file for fuzz tests
ACKs for top commit:
practicalswift:
ACK fa69f88486e900aacf3fc768671f947927173226 -- patch looks correct
Tree-SHA512: f61beb6c94a9ab664deb191685fcad601e228b77bb1c43db6ec40616ae393c9dd35c51474f1b0759ac0bc29b5ca8456a329906a3695bd0f18fa4372210c8b54a
Diffstat (limited to 'src/bench/bench_bitcoin.cpp')
-rw-r--r-- | src/bench/bench_bitcoin.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/bench/bench_bitcoin.cpp b/src/bench/bench_bitcoin.cpp index 9235d5fe6a..2d44264e53 100644 --- a/src/bench/bench_bitcoin.cpp +++ b/src/bench/bench_bitcoin.cpp @@ -73,6 +73,8 @@ int main(int argc, char** argv) gArgs.GetArg("-plot-height", DEFAULT_PLOT_HEIGHT))); } + gArgs.ClearArgs(); // gArgs no longer needed. Clear it here to avoid interactions with the testing setup in the benches + benchmark::BenchRunner::RunAll(*printer, evaluations, scaling_factor, regex_filter, is_list_only); return EXIT_SUCCESS; |