diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-11-25 17:01:57 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-11-25 17:02:20 +0100 |
| commit | 50091592dd875a1c94030dbed74112b003732d68 (patch) | |
| tree | f78cf8531e2e7dc80b28307609d19165cdc67b88 /src/base58.h | |
| parent | 19b8071eaeb32dbe39ccc771dbe6095dd9285779 (diff) | |
| parent | 95975dd08d8fdaaeaf28e0d06b861ce2748c17b6 (diff) | |
Merge #19337: sync: detect double lock from the same thread
95975dd08d8fdaaeaf28e0d06b861ce2748c17b6 sync: detect double lock from the same thread (Vasil Dimov)
4df6567e4cbb4677e8048de2f8008612e1b860b9 sync: make EnterCritical() & push_lock() type safe (Vasil Dimov)
Pull request description:
Double lock of the same (non-recursive) mutex from the same thread would produce an undefined behavior. Detect this from `DEBUG_LOCKORDER` and react similarly to the deadlock detection.
This came up during discussion in another, related PR: https://github.com/bitcoin/bitcoin/pull/19238#discussion_r442394521.
ACKs for top commit:
laanwj:
code review ACK 95975dd08d8fdaaeaf28e0d06b861ce2748c17b6
hebasto:
re-ACK 95975dd08d8fdaaeaf28e0d06b861ce2748c17b6
Tree-SHA512: 375c62db7819e348bfaecc3bd82a7907fcd8f5af24f7d637ac82f3f16789da9fc127dbd0e37158a08e0dcbba01a55c6635caf1d8e9e827cf5a3747f7690a498e
Diffstat (limited to 'src/base58.h')
0 files changed, 0 insertions, 0 deletions