diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-08-21 08:21:54 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-08-21 08:22:25 -0400 |
| commit | 6dfa9efa3f558deaca0f01f673c79cce2b92a2b3 (patch) | |
| tree | e79c4bc7f766698205a51e1d5db743f6350ca16d /src/banman.cpp | |
| parent | 01ebaa05a4872f3cf29745b3a51777cd5fe7af82 (diff) | |
| parent | 6011c9d72d1df5c2cd09de6f85c21eb4f7eb1ba8 (diff) | |
Merge #16656: test: fix rpc_setban.py race
6011c9d72d1df5c2cd09de6f85c21eb4f7eb1ba8 QA: fix rpc_setban.py race (Jonas Schnelli)
Pull request description:
The new `rpc_setban.py` test failes regularly on CIs due to a race between injecting the ban and testing the log "on the other side".
The problem is, that the test immediately after the `addnode` command on node0 checks for the `dropped (banned)` entry on node1 (without giving some time).
Adding a 2 seconds sleep seems to solve the race (I guess there is no better event-driven delay).
Example of a failed test: https://bitcoinbuilds.org/index.php?ansilog=bf743910-103f-4b54-9a97-960c471061bd.log#l2906
Top commit has no ACKs.
Tree-SHA512: 680f8ea3e5ddb07e93f824f1aeff4a459e25e6c14715a39fc7670e50506d7cf25925348672c5c2d8ba3e1243ccf5effbc2456bcd094fb96868349f8d26e008f1
Diffstat (limited to 'src/banman.cpp')
0 files changed, 0 insertions, 0 deletions