refactor: Apply consistent pattern for CAddrMan::Check usage

Co-authored-by: John Newbery <john@johnnewbery.com>

1 files changed, 8 insertions, 14 deletions

diff --git a/src/addrman.h b/src/addrman.h
index 3474153e36..2250d1a14c 100644
--- a/src/addrman.h
+++ b/src/addrman.h
@@ -551,13 +551,10 @@ public:
     //! Randomly select an address in tried that another address is attempting to evict.
     CAddrInfo SelectTriedCollision()
     {
-        CAddrInfo ret;
-        {
-            LOCK(cs);
-            Check();
-            ret = SelectTriedCollision_();
-            Check();
-        }
+        LOCK(cs);
+        Check();
+        const CAddrInfo ret = SelectTriedCollision_();
+        Check();
         return ret;
     }
 
@@ -566,13 +563,10 @@ public:
      */
     CAddrInfo Select(bool newOnly = false)
     {
-        CAddrInfo addrRet;
-        {
-            LOCK(cs);
-            Check();
-            addrRet = Select_(newOnly);
-            Check();
-        }
+        LOCK(cs);
+        Check();
+        const CAddrInfo addrRet = Select_(newOnly);
+        Check();
         return addrRet;
     }