diff options
author | Vasil Dimov <vd@FreeBSD.org> | 2021-07-19 14:13:35 +0200 |
---|---|---|
committer | Vasil Dimov <vd@FreeBSD.org> | 2021-07-19 14:33:21 +0200 |
commit | d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678 (patch) | |
tree | 1f2609c8d00e6c2bc36bb6dcacf85a8d16b01e31 /src/addrman.h | |
parent | d3474b8df2f973e9b9142c0b64505a8a78bcb292 (diff) |
scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14)
`CAddrMan::ResetI2PPorts()` was temporary. Remove it:
* it has partially achieved its goal: probably ran on about half of the
I2P nodes
* it is hackish, deemed risky and two bugs where found in it
https://github.com/bitcoin/bitcoin/issues/22467
https://github.com/bitcoin/bitcoin/issues/22470
-BEGIN VERIFY SCRIPT-
git show e0a2b390c144e123e2fc8a289fdff36815476964 |git apply -R
-END VERIFY SCRIPT-
Fixes https://github.com/bitcoin/bitcoin/issues/22467
Fixes https://github.com/bitcoin/bitcoin/issues/22470
Diffstat (limited to 'src/addrman.h')
-rw-r--r-- | src/addrman.h | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/addrman.h b/src/addrman.h index 2a5c6c06b4..c2f425f2fa 100644 --- a/src/addrman.h +++ b/src/addrman.h @@ -452,8 +452,6 @@ public: RemoveInvalid(); - ResetI2PPorts(); - Check(); } @@ -769,14 +767,6 @@ private: //! Remove invalid addresses. void RemoveInvalid() EXCLUSIVE_LOCKS_REQUIRED(cs); - /** - * Reset the ports of I2P peers to 0. - * This is needed as a temporary measure because now we enforce port 0 and - * only connect to I2P hosts if the port is 0, but in the early days some - * I2P addresses with port 8333 were rumoured and persisted into addrmans. - */ - void ResetI2PPorts() EXCLUSIVE_LOCKS_REQUIRED(cs); - friend class CAddrManTest; }; |