diff options
| author | fanquake <fanquake@gmail.com> | 2021-07-20 08:59:02 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-07-20 09:02:34 +0800 |
| commit | 624a19333022e53aaa56553797bbc5ba94982968 (patch) | |
| tree | 84718247a95d57a0f76fd0c55e3adf7493ce508c /src/addrman.h | |
| parent | 54e31742d208eb98ce706aaa6bbd4b023f42c3a5 (diff) | |
| parent | d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678 (diff) | |
| download | bitcoin-624a19333022e53aaa56553797bbc5ba94982968.tar.xz | |
Merge bitcoin/bitcoin#22497: scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14)
d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678 scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14) (Vasil Dimov)
Pull request description:
`CAddrMan::ResetI2PPorts()` was temporary. Remove it:
* it has partially achieved its goal: probably ran on about half of the
I2P nodes
* it is hackish, deemed risky and two bugs where found in it:
https://github.com/bitcoin/bitcoin/issues/22467
https://github.com/bitcoin/bitcoin/issues/22470
-BEGIN VERIFY SCRIPT-
git show e0a2b390c144e123e2fc8a289fdff36815476964 |git apply -R
-END VERIFY SCRIPT-
Fixes https://github.com/bitcoin/bitcoin/issues/22467
Fixes https://github.com/bitcoin/bitcoin/issues/22470
ACKs for top commit:
laanwj:
ACK d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678
MarcoFalke:
review ACK d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678 😲
jonatack:
ACK d4b67c8ebc2bb7488bcaaccc3a801cdef1cf1678 per IRC discussions https://www.erisian.com.au/bitcoin-core-dev/log-2021-07-16.html#l-212 and https://www.erisian.com.au/bitcoin-core-dev/log-2021-07-19.html#l-210
Tree-SHA512: 60d8f0ea0f66a8fcedfcb9c8944a419b974b15509b54ddfeec58db49ae9418e6916df712bba3fbd6b29497d85f7951fb9aa2e48eb9c59f88d09435685bd00b4c
Diffstat (limited to 'src/addrman.h')
| -rw-r--r-- | src/addrman.h | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/addrman.h b/src/addrman.h index 5de90653c1..6f081b8dc1 100644 --- a/src/addrman.h +++ b/src/addrman.h @@ -458,8 +458,6 @@ public: RemoveInvalid(); - ResetI2PPorts(); - Check(); } @@ -775,14 +773,6 @@ private: //! Remove invalid addresses. void RemoveInvalid() EXCLUSIVE_LOCKS_REQUIRED(cs); - /** - * Reset the ports of I2P peers to 0. - * This is needed as a temporary measure because now we enforce port 0 and - * only connect to I2P hosts if the port is 0, but in the early days some - * I2P addresses with port 8333 were rumoured and persisted into addrmans. - */ - void ResetI2PPorts() EXCLUSIVE_LOCKS_REQUIRED(cs); - friend class CAddrManTest; }; |