diff options
author | junderw <junderwood@bitcoinbank.co.jp> | 2022-01-29 21:58:59 +0900 |
---|---|---|
committer | junderw <junderwood@bitcoinbank.co.jp> | 2022-02-25 09:53:10 +0900 |
commit | d41ed3215355582879c8eb6c99c2da33852f6cb1 (patch) | |
tree | da4d170ee99b2d621a19645e5840c07fd95cb76b /src/addrdb.cpp | |
parent | 5b4b8f76f3ae11064d4aa3ac157558e364751fd2 (diff) | |
download | bitcoin-d41ed3215355582879c8eb6c99c2da33852f6cb1.tar.xz |
p2p: Avoid InitError when downgrading peers.dat
fixes #24188
When downgrading, a peers.dat with a future version that has a minimum
required version larger than the downgraded version would cause an InitError.
This commit changes this behavior to overwrite the existing peers.dat with
a new empty one, while creating a backup in peers.dat.bak.
Diffstat (limited to 'src/addrdb.cpp')
-rw-r--r-- | src/addrdb.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/src/addrdb.cpp b/src/addrdb.cpp index 94518b88d8..9f3e2e7219 100644 --- a/src/addrdb.cpp +++ b/src/addrdb.cpp @@ -196,6 +196,15 @@ std::optional<bilingual_str> LoadAddrman(const std::vector<bool>& asmap, const A addrman = std::make_unique<AddrMan>(asmap, /* deterministic */ false, /* consistency_check_ratio */ check_addrman); LogPrintf("Creating peers.dat because the file was not found (%s)\n", fs::quoted(fs::PathToString(path_addr))); DumpPeerAddresses(args, *addrman); + } catch (const InvalidAddrManVersionError&) { + if (!RenameOver(path_addr, (fs::path)path_addr + ".bak")) { + addrman = nullptr; + return strprintf(_("Failed to rename invalid peers.dat file. Please move or delete it and try again.")); + } + // Addrman can be in an inconsistent state after failure, reset it + addrman = std::make_unique<AddrMan>(asmap, /* deterministic */ false, /* consistency_check_ratio */ check_addrman); + LogPrintf("Creating new peers.dat because the file version was not compatible (%s). Original backed up to peers.dat.bak\n", fs::quoted(fs::PathToString(path_addr))); + DumpPeerAddresses(args, *addrman); } catch (const std::exception& e) { addrman = nullptr; return strprintf(_("Invalid or corrupt peers.dat (%s). If you believe this is a bug, please report it to %s. As a workaround, you can move the file (%s) out of the way (rename, move, or delete) to have a new one created on the next start."), |