diff options
author | MarcoFalke <falke.marco@gmail.com> | 2021-02-17 10:40:02 +0100 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2021-02-17 10:40:09 +0100 |
commit | 569b5ba1dc56ef1df2fc7dbf22b5fdbf35c87556 (patch) | |
tree | b210d9036aab0b50808261fd5b25cfc8a45595a0 /src/Makefile.test_util.include | |
parent | 8639c446d88b5d521485dbec00029b3028d01492 (diff) | |
parent | 1363b6c27dbd2614fd555d148ea624ed8b95f14e (diff) | |
download | bitcoin-569b5ba1dc56ef1df2fc7dbf22b5fdbf35c87556.tar.xz |
Merge #21121: [test] Small unit test improvements, including helper to make mempool transaction
1363b6c27dbd2614fd555d148ea624ed8b95f14e [doc / util] Use comments to clarify time unit for int64_t type. (Amiti Uttarwar)
47a7a1687d276bfa8769dee4bb78e8725f67a50e [util] Introduce a SetMockTime that takes chrono time (Amiti Uttarwar)
df6a5fc1dff3b1b7c2f2b67aad1ff17cac99f7b6 [util] Change GetMockTime to return chrono type instead of int (Amiti Uttarwar)
a2d908e1daa1d1be74568bd7d1d04b724da7d79c [test] Throw error instead of segfaulting in failure scenario (Amiti Uttarwar)
9a3bbe8fc57d88919acd4eadbc96124711f17ec2 [test] Introduce a unit test helper to create a valid mempool transaction. (Amiti Uttarwar)
Pull request description:
Some miscellaneous improvements that came up when working on #21061
- The first commit is a helper to make valid mempool transactions & submit via ATMP. Introducing in this PR, using in #21061.
- The second commit is a small improvement in `miner_tests.cpp` that uses `BOOST_REQUIRE_EQUAL` to properly terminate the program instead of segfaulting in the failure scenario where the blocks do not include the expected number of transactions.
- The third commit changes the function signature of `GetMockTime()` to return a chrono type.
- The fourth & fifth commit overload `SetMockTime` to also accept chrono type, and adds documentation to indicate that the `int64_t` function signature is deprecated.
ACKs for top commit:
vasild:
ACK 1363b6c27dbd2614fd555d148ea624ed8b95f14e
Tree-SHA512: c72574d73668ea04ee4c33858f8de68b368780f445e05afb569aaf8564093f8112259b3afe93cf6dc2ee12a1ab5af1130ac73c16416132c1ba2851c054a67d78
Diffstat (limited to 'src/Makefile.test_util.include')
0 files changed, 0 insertions, 0 deletions